osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

RLC LTE graph: add comments clarifying tracer limitation 

Change-Id: Ib6a79689ced9377b1ac00513810db2e86d26d83f
Reviewed-on: https://code.wireshark.org/review/24690
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Martin Mathieson 2017-12-03 20:26:05 +00:00 committed by Anders Broman
parent f411ab3988
commit 5350fd741f
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui/qt/lte_rlc_graph_dialog.cpp
View File

@ -304,6 +304,8 @@ void LteRlcGraphDialog::fillGraph()
mouseMoved(NULL);
resetAxes();
// This is why, in mouseMoved(), we only match the entries
// corresponding to data segments (base_graph_)...
tracer_->setGraph(base_graph_);
// XXX QCustomPlot doesn't seem to draw any sort of focus indicator.
@ -597,6 +599,9 @@ void LteRlcGraphDialog::mouseMoved(QMouseEvent *event)
tracer_->setVisible(true);
packet_num_ = packet_seg->num;
// N.B. because tracer only looks up entries in base_graph_,
// we know that packet_seg will be a data segment, so no need to check
// iscontrolPDU or isResegmented fields.
hint += tr("%1 %2 (%3s seq %4 len %5)")
.arg(cap_file_.capFile() ? tr("Click to select packet") : tr("Packet"))
.arg(packet_num_)