osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Update LACP Dissector 

Add a FIXME wrt validation of DMAC

Change-Id: I4dac16ab18c32c6eac444bfc5db05d6be17dcf22
Reviewed-on: https://code.wireshark.org/review/35199
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
This commit is contained in:
Joerg Mayer 2019-11-10 11:06:30 +01:00 committed by Jörg Mayer
parent 27f9606932
commit 4e18ef9b0e
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
epan/dissectors/packet-lacp.c
View File

@ -188,6 +188,14 @@ dissect_lacp(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree, void* data _U_
col_set_str(pinfo->cinfo, COL_PROTOCOL, "LACP");
col_set_str(pinfo->cinfo, COL_INFO, "Link Aggregation Control Protocol");
/* FIXME
* Validate that the destination MAC address is one of the following
* (IEEE 802.1AX-2014 6.2.11.2):
* 01-80-C2-00-00-00: Nearest Customer Bridge group address
* 01-80-C2-00-00-02: IEEE 802.3 Slow_Protocols_Mulitcast group address
* 01-80-C2-00-00-03: Nearest non-TPMR Bridge group address
*/
/* Add LACP Heading - Note: 1 byte for slowprotocol has been consumed already */
lacp_item = proto_tree_add_protocol_format(tree, proto_lacp, tvb,
0, -1, "Link Aggregation Control Protocol");