osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Fix byte pane not showing up in Packet dialog 

When a packet dialog is being constructed, the layout is apparently not
fixed yet and the byte view is technically not visible. Fix the hidden
byte pane by not hiding it when it is not (yet) visible.

Bug: 11760
Change-Id: I0494fa16a5ed89ff31f934ba682a6bb884cc0e2e
Reviewed-on: https://code.wireshark.org/review/14713
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Peter Wu 2016-03-30 23:49:06 +02:00 committed by Alexis La Goutte
parent ad097385c0
commit 4de738f5a7
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui/qt/byte_view_tab.cpp
View File

@ -58,12 +58,16 @@ void ByteViewTab::addTab(const char *name, tvbuff_t *tvb, proto_tree *tree, QTre
void ByteViewTab::clear()
{
bool visible = isVisible();
hide();
if (visible) {
hide();
}
while (currentWidget()) {
delete currentWidget();
}
addTab();
setVisible(visible);
if (visible) {
show();
}
}
// XXX How many hex dump routines do we have?