osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Add a comment explaining why we treat OUI_HP_2 specially. 

Change-Id: If5c7cd0bb673767b95db8981018e2e67135fef63
Reviewed-on: https://code.wireshark.org/review/36912
Reviewed-by: Guy Harris <gharris@sonic.net>
This commit is contained in:
Guy Harris 2020-04-23 20:34:55 -07:00 committed by Guy Harris
parent 485476d0d2
commit 4b503b1f0e
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
epan/dissectors/packet-llc.c
View File

@ -519,6 +519,21 @@ dissect_snap(tvbuff_t *tvb, int offset, packet_info *pinfo, proto_tree *tree,
switch (oui) {
case OUI_HP_2:
/*
* We don't use the standard SNAP OUI mechanism here
* because that only calls the subdissector for
* information frames, and, according to the HP document
* at
*
* http://www.hp.com/sbso/bus_protect/teaming.pdf
*
* the heartbeats are sent to 03-00-C7-00-00-EE in SNAP
* frames in unnumbered TEST frames, not information
* frames (numbered or unnumbered).
*
* See the comment in epan/dissectors/packet-hpteam.c
* for more details.
*/
oui_info = get_snap_oui_info(oui);
hf = *oui_info->field_info->p_id;
proto_tree_add_uint(snap_tree, hf, tvb, offset+3, 2, etype);