osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Fix a Coverity complaint. 

For all cases in topic_action_url(), set url and break out of the switch
statement.

For the default case, set the URL to WS_HOME_PAGE_URL - we should never
get there, as here's a g_assert_not_reached() call before that, but this
should squelch Coverity's complaint.

Should fix Coverity CID 1467697.
This commit is contained in:
Guy Harris 2020-10-04 00:59:48 -07:00
parent d76ee2cb89
commit 4a9c412218
1 changed files with 14 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
ui/help_url.c
View File

@ -81,43 +81,43 @@ topic_action_url(topic_action_e action)
switch(action) {
/* pages online at www.wireshark.org */
case(ONLINEPAGE_HOME):
return WS_HOME_PAGE_URL;
url = WS_HOME_PAGE_URL;
break;
case(ONLINEPAGE_WIKI):
return WS_WIKI_HOME_URL;
url = WS_WIKI_HOME_URL;
break;
case(ONLINEPAGE_DOWNLOAD):
return WS_DOWNLOAD_URL;
url = WS_DOWNLOAD_URL;
break;
case(ONLINEPAGE_DOCS):
return WS_DOCS_URL;
url = WS_DOCS_URL;
break;
case(ONLINEPAGE_USERGUIDE):
return WS_DOCS_URL "/wsug_html_chunked/";
url = WS_DOCS_URL "/wsug_html_chunked/";
break;
case(ONLINEPAGE_FAQ):
return WS_FAQ_URL;
url = WS_FAQ_URL;
break;
case(ONLINEPAGE_ASK):
return WS_Q_AND_A_URL;
url = WS_Q_AND_A_URL;
break;
case(ONLINEPAGE_SAMPLE_FILES):
return WS_WIKI_URL("SampleCaptures");
url = WS_WIKI_URL("SampleCaptures");
break;
case(ONLINEPAGE_CAPTURE_SETUP):
return WS_WIKI_URL("CaptureSetup");
url = WS_WIKI_URL("CaptureSetup");
break;
case(ONLINEPAGE_NETWORK_MEDIA):
return WS_WIKI_URL("CaptureSetup/NetworkMedia");
url = WS_WIKI_URL("CaptureSetup/NetworkMedia");
break;
case(ONLINEPAGE_SAMPLE_CAPTURES):
return WS_WIKI_URL("SampleCaptures");
url = WS_WIKI_URL("SampleCaptures");
break;
case(ONLINEPAGE_SECURITY):
return WS_WIKI_URL("Security");
url = WS_WIKI_URL("Security");
break;
case(ONLINEPAGE_CHIMNEY):
return WS_WIKI_URL("CaptureSetup/Offloading#chimney");
url = WS_WIKI_URL("CaptureSetup/Offloading#chimney");
break;
/* local manual pages */
@ -314,6 +314,7 @@ topic_action_url(topic_action_e action)
case(TOPIC_ACTION_NONE):
default:
g_assert_not_reached();
url = WS_HOME_PAGE_URL;
}
return url;