osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Qt (KeyPressEvent): Missing break in switch (CID 1159205, 1159206, 1159208, 1159209) 

Change-Id: I40b7c7eefb269570e6a1c5c9ec310fa97840d42d
Reviewed-on: https://code.wireshark.org/review/5995
Reviewed-by: Anders Broman <a.broman58@gmail.com>
This commit is contained in:
Alexis La Goutte 2014-12-22 20:54:10 +01:00 committed by Anders Broman
parent 2d8ec49ffa
commit 4876016bda
4 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ui/qt/column_preferences_frame.cpp
View File

@ -137,6 +137,7 @@ void ColumnPreferencesFrame::keyPressEvent(QKeyEvent *evt)
case Qt::Key_Escape:
cur_line_edit_->setText(saved_col_string_);
new_idx = saved_combo_idx_;
/* Fall Through */
case Qt::Key_Enter:
case Qt::Key_Return:
switch (cur_column_) {
@ -164,6 +165,7 @@ void ColumnPreferencesFrame::keyPressEvent(QKeyEvent *evt)
switch (evt->key()) {
case Qt::Key_Escape:
cur_combo_box_->setCurrentIndex(saved_combo_idx_);
/* Fall Through */
case Qt::Key_Enter:
case Qt::Key_Return:
// XXX The combo box eats enter and return

1
ui/qt/filter_expressions_preferences_frame.cpp
View File

@ -130,6 +130,7 @@ void FilterExpressionsPreferencesFrame::keyPressEvent(QKeyEvent *evt)
switch (evt->key()) {
case Qt::Key_Escape:
cur_line_edit_->setText(saved_col_string_);
/* Fall Through */
case Qt::Key_Enter:
case Qt::Key_Return:
switch (cur_column_) {

2
ui/qt/preferences_dialog.cpp
View File

@ -362,6 +362,7 @@ void PreferencesDialog::keyPressEvent(QKeyEvent *evt)
switch (evt->key()) {
case Qt::Key_Escape:
cur_line_edit_->setText(saved_string_pref_);
/* Fall Through */
case Qt::Key_Enter:
case Qt::Key_Return:
switch (cur_pref_type_) {
@ -387,6 +388,7 @@ void PreferencesDialog::keyPressEvent(QKeyEvent *evt)
switch (evt->key()) {
case Qt::Key_Escape:
cur_combo_box_->setCurrentIndex(saved_combo_idx_);
/* Fall Through */
case Qt::Key_Enter:
case Qt::Key_Return:
// XXX The combo box eats enter and return

2
ui/qt/uat_dialog.cpp
View File

@ -125,6 +125,7 @@ void UatDialog::keyPressEvent(QKeyEvent *evt)
switch (evt->key()) {
case Qt::Key_Escape:
cur_line_edit_->setText(saved_string_pref_);
/* Fall Through */
case Qt::Key_Enter:
case Qt::Key_Return:
stringPrefEditingFinished();
@ -136,6 +137,7 @@ void UatDialog::keyPressEvent(QKeyEvent *evt)
switch (evt->key()) {
case Qt::Key_Escape:
cur_combo_box_->setCurrentIndex(saved_combo_idx_);
/* Fall Through */
case Qt::Key_Enter:
case Qt::Key_Return:
// XXX The combo box eats enter and return