osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Qt: Fixed a resource leak in getFilterFromRowAndColumn 

Found by coverity CID 1314608 and Apple Instruments.

Change-Id: I264ce335bd8985946a097bb8f99f7c41c0eb027d
Reviewed-on: https://code.wireshark.org/review/10378
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
This commit is contained in:
Stig Bjørlykke 2015-09-04 12:22:30 +02:00
parent e438374990
commit 47f5d41acd
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ui/qt/packet_list.cpp
View File

@ -799,10 +799,10 @@ bool PacketList::contextMenuActive()
return ctx_column_ >= 0 ? true : false;
}
const QString &PacketList::getFilterFromRowAndColumn()
QString PacketList::getFilterFromRowAndColumn()
{
frame_data *fdata;
QString &filter = *new QString();
QString filter;
int row = currentIndex().row();
if (!cap_file_ || !packet_list_model_ || ctx_column_ < 0 || ctx_column_ >= cap_file_->cinfo.num_cols) return filter;

2
ui/qt/packet_list.h
View File

@ -66,7 +66,7 @@ public:
void clear();
void writeRecent(FILE *rf);
bool contextMenuActive();
const QString &getFilterFromRowAndColumn();
QString getFilterFromRowAndColumn();
void resetColorized();
QString packetComment();
void setPacketComment(QString new_comment);