osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Fix the use of va_args in the new expert code. Passing a va_list to a ... is 

valid, but doesn't do what you actually want most of the time.

svn path=/trunk/; revision=50392
This commit is contained in:
Evan Huus 2013-07-05 23:53:25 +00:00
parent 7fb1b4ab37
commit 34cd52a8e5
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
epan/expert.c
View File

@ -437,9 +437,13 @@ proto_tree_add_expert_format(proto_tree *tree, packet_info *pinfo, expert_field*
EXPERT_REGISTRAR_GET_NTH(expindex->ei, eiinfo);
va_start(ap, format);
ti = proto_tree_add_text(tree, tvb, start, length, format, ap);
ti = proto_tree_add_text_valist(tree, tvb, start, length, format, ap);
va_end(ap);
va_start(ap, format);
expert_set_info_vformat(pinfo, ti, eiinfo->group, eiinfo->severity, *eiinfo->hf_info.p_id, TRUE, format, ap);
va_end(ap);
return ti;
}