osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Qt: remove leak from PathChooserDelegate (found by clang). 

Change-Id: I71d73c8464450f8cbc655f8f99f54bd34eddd344
Reviewed-on: https://code.wireshark.org/review/25374
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
This commit is contained in:
Dario Lombardo 2018-01-18 18:29:24 +01:00 committed by Alexis La Goutte
parent 8631ceaefc
commit 24cd7a9a1f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui/qt/models/path_chooser_delegate.cpp
View File

@ -93,7 +93,8 @@ void PathChooserDelegate::browse_button_clicked()
break;
}
QString file_name = QFileDialog::getOpenFileName(new QWidget(), tr("Open Pipe"), open_dir);
QWidget * qw = new QWidget();
QString file_name = QFileDialog::getOpenFileName(qw, tr("Open Pipe"), open_dir);
if ( !file_name.isEmpty() )
{
QWidget * parent = ((QPushButton *)sender())->parentWidget();
@ -102,9 +103,9 @@ void PathChooserDelegate::browse_button_clicked()
{
lineEdit->setText(file_name);
emit commitData(parent);
}
}
delete(qw);
}
void PathChooserDelegate::setEditorData(QWidget *editor, const QModelIndex &idx) const