osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

docs: remove references to gerrit.

This commit is contained in:
Dario Lombardo 2020-10-16 08:40:12 +02:00 committed by Wireshark GitLab Utility
parent cf83a67fd3
commit 1fbc6315c0
2 changed files with 9 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docbook/wsdg_src/WSDG_chapter_quick_setup.adoc
View File

@ -275,7 +275,7 @@ Using the command line:
---- ----
>cd C:\Development >cd C:\Development
>git clone https://code.wireshark.org/review/wireshark >git clone https://gitlab.com/wireshark/wireshark.git
---- ----
Using Git extensions: Using Git extensions:
@ -287,7 +287,7 @@ Using Git extensions:
. In the main screen select _Clone repository_. Fill in the following: . In the main screen select _Clone repository_. Fill in the following:
+ +
Repository to clone: *`https://code.wireshark.org/review/wireshark`* Repository to clone: *`https://gitlab.com/wireshark/wireshark.git`*
+ +
Destination: Your top-level development directory, e.g. _C:\Development_. Destination: Your top-level development directory, e.g. _C:\Development_.
+ +

28
docbook/wsdg_src/WSDG_chapter_sources.adoc
View File

@ -653,37 +653,23 @@ See {wireshark-wiki-url}FuzzTesting for details.
When you're satisfied with your changes (and obtained any necessary When you're satisfied with your changes (and obtained any necessary
approval from your organization) you can upload them for review at approval from your organization) you can upload them for review at
{wireshark-code-review-url}. This requires a Gerrit Code Review account {wireshark-code-review-url}. This requires a Gitlab account
as described at <<ChSrcGitRepository>>. as described at <<ChSrcGitRepository>>.
Changes should be pushed to a You need to fork your repository which will became yours, and you will have write access to it. Once
https://code.wireshark.org/review/Documentation/user-upload.html#push_create[magical "refs/for" branch] you are done with your changes, push them to a branch of your choice (as snowcone-machine). Now in the
in Gerrit. For example, to upload your new Snowcone Machine Protocol dissector Gitlab's UI a message will tell you that you created a new branch and a button to create a merge request.
you could push to refs/for/master with the topic "snowcone-machine":
[source,sh] [source,sh]
---- ----
$ git push ssh://my.username@code.wireshark.org:29418/wireshark HEAD:refs/for/master/snowcone-machine $ git push https://gitlab.com/wireshark/<my.username>.git HEAD:<branchname>
---- ----
The username `my.username` is the one which was given during registration with The username `my.username` is the one which was given during registration with
the review system. the review system.
If you have `git-review` installed you can upload the change with a lot less typing: You can push using any Git client.
[source,sh]
----
# Note: The "-f" flag deletes your current branch.
git review -f
----
You can push using any Git client. Many clients have support for Gerrit, either
built in or via an additional module.
The Change-Id is very relevant in the review process, since it's the key used
to identify one change. See the
https://gerrit-review.googlesource.com/Documentation/user-changeid.html[Gerrit manual]
for more details.
You might get one of the following responses to your patch request: You might get one of the following responses to your patch request: