From 1cf16845048c6898c95ba853f4579f56920554c6 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Mon, 1 Nov 2021 13:38:36 -0700 Subject: [PATCH] README.developer: put items about Windows together. Move the item about MinGW-w64 up after the earlier item about Windows portability in general. --- doc/README.developer | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/README.developer b/doc/README.developer index 90089923dd..1811a89a1c 100644 --- a/doc/README.developer +++ b/doc/README.developer @@ -426,10 +426,6 @@ platform-dependent implementations and platform-independent APIs, such as the routines in epan/filesystem.c, allowing the code that calls it to be written portably without #ifdefs. -Wireshark uses Libgcrypt as general-purpose crypto library. To use it from -your dissector, do not include gcrypt.h directly, but use the wrapper file -wsutil/wsgcrypt.h instead. - We support building on Windows using MinGW-w64 (experimental) so be mindful of the difference between an #ifdef on _WIN32 and _MSC_VER. The first tests if the platform is some version of Windows and also applies to MinGW. The @@ -440,6 +436,10 @@ a MinGW toolchain, including MinGW-w64. The same concern applies to CMake code. Depending on the particular situation you may need to use if(WIN32) or if(MSVC) or if(MINGW). +Wireshark uses Libgcrypt as general-purpose crypto library. To use it from +your dissector, do not include gcrypt.h directly, but use the wrapper file +wsutil/wsgcrypt.h instead. + 2. String handling Do not use functions such as strcat() or strcpy().