From 1bb64b7e0ca46442b3f3a65e4b99893674b3c287 Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Sun, 23 May 2021 17:04:59 -0700 Subject: [PATCH] tacacs: free a buffer if it's not used. Plugs a leak. --- epan/dissectors/packet-tacacs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/epan/dissectors/packet-tacacs.c b/epan/dissectors/packet-tacacs.c index 223678d3d5..fdd6e98c13 100644 --- a/epan/dissectors/packet-tacacs.c +++ b/epan/dissectors/packet-tacacs.c @@ -797,8 +797,10 @@ mkipv4_address( address **addr, const char *str_addr ) ret = str_to_ip(str_addr, addr_data); if (ret) set_address(*addr, AT_IPv4, 4, addr_data); - else + else { + g_free(addr_data); /* not set, not used */ set_address(*addr, AT_STRINGZ, (int)strlen(ADDR_INVLD)+1, ADDR_INVLD); + } } static void parse_tuple( char *key_from_option )