From 1999ad7479a1f615fadf09b413a860d4cfddc68b Mon Sep 17 00:00:00 2001 From: Alexis La Goutte Date: Thu, 25 Apr 2019 18:58:58 +0000 Subject: [PATCH] eap: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang Change-Id: I1ab6fc7ec046038ab130aef994081051a7f40e19 Reviewed-on: https://code.wireshark.org/review/32987 Petri-Dish: Alexis La Goutte Tested-by: Petri Dish Buildbot Reviewed-by: Anders Broman --- epan/dissectors/packet-eap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/epan/dissectors/packet-eap.c b/epan/dissectors/packet-eap.c index ea79dd11e3..baa88e3867 100644 --- a/epan/dissectors/packet-eap.c +++ b/epan/dissectors/packet-eap.c @@ -409,7 +409,7 @@ static const value_string eap_ext_vendor_type_vals[] = { static void dissect_exteap(proto_tree *eap_tree, tvbuff_t *tvb, int offset, - gint size, packet_info* pinfo, guint8 eap_code, guint8 eap_identifier) + gint size _U_, packet_info* pinfo, guint8 eap_code, guint8 eap_identifier) { tvbuff_t *next_tvb; guint32 vendor_id; @@ -420,11 +420,9 @@ dissect_exteap(proto_tree *eap_tree, tvbuff_t *tvb, int offset, proto_tree_add_item_ret_uint(eap_tree, hf_eap_ext_vendor_id, tvb, offset, 3, ENC_BIG_ENDIAN, &vendor_id); offset += 3; - size -= 3; proto_tree_add_item_ret_uint(eap_tree, hf_eap_ext_vendor_type, tvb, offset, 4, ENC_BIG_ENDIAN, &vendor_type); offset += 4; - size -= 4; vendor_context->eap_code = eap_code; vendor_context->eap_identifier = eap_identifier;