From 17b2a16b5afe321126b5bbb642c6b23fd2924f06 Mon Sep 17 00:00:00 2001 From: Nardi Ivan Date: Wed, 30 Dec 2020 15:49:06 +0000 Subject: [PATCH] TLS: fix display of Google QUIC Version in Transport Parameters (cherry picked from commit a23915c9a86ae8d4b5a497b114b06d7835ed9070) --- epan/dissectors/packet-tls-utils.c | 2 +- epan/dissectors/packet-tls-utils.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/epan/dissectors/packet-tls-utils.c b/epan/dissectors/packet-tls-utils.c index 0c9580f804..8ac3929a36 100644 --- a/epan/dissectors/packet-tls-utils.c +++ b/epan/dissectors/packet-tls-utils.c @@ -7528,7 +7528,7 @@ ssl_dissect_hnd_hello_ext_quic_transport_parameters(ssl_common_dissect_t *hf, tv case SSL_HND_QUIC_TP_GOOGLE_QUIC_VERSION: for (i = 0; i < parameter_length; i += 4) { proto_tree_add_item(parameter_tree, hf->hf.hs_ext_quictp_parameter_google_quic_version, - tvb, offset + i, 4, ENC_ASCII|ENC_NA); + tvb, offset + i, 4, ENC_BIG_ENDIAN); } offset += parameter_length; break; diff --git a/epan/dissectors/packet-tls-utils.h b/epan/dissectors/packet-tls-utils.h index b9792e61cd..2923d46908 100644 --- a/epan/dissectors/packet-tls-utils.h +++ b/epan/dissectors/packet-tls-utils.h @@ -2224,7 +2224,7 @@ ssl_common_dissect_t name = { \ }, \ { & name .hf.hs_ext_quictp_parameter_google_quic_version, \ { "Google QUIC version", prefix ".quic.parameter.google.quic_version", \ - FT_STRING, BASE_NONE, NULL, 0x00, \ + FT_UINT32, BASE_HEX, VALS(quic_version_vals), 0x00, \ NULL, HFILL } \ }, \ { & name .hf.hs_ext_quictp_parameter_google_initial_rtt, \