From Fritz Budiyanto: the command in the Packet Transfer Command IE is

one byte, so fetch it with "tvb_get_guint8()", not "tvb_get_ntohl()".

Put in the location in the GPRS standard where that's defined, while
we're at it.

svn path=/trunk/; revision=6533
This commit is contained in:
Guy Harris 2002-11-01 05:30:48 +00:00
parent cdb4e6929c
commit 1522cd2994
3 changed files with 8 additions and 3 deletions

View File

@ -1473,6 +1473,10 @@ Peter Fales <psfales [AT] lucent.com> {
ARCNET support
}
Fritz Budiyanto <fritzb88 [AT] yahoo.com> {
Fix for GTP Packet Transfer Command IE
}
Alain Magloire <alainm[AT]rcsm.ece.mcgill.ca> was kind enough to
give his permission to use his version of snprintf.c.

View File

@ -1567,6 +1567,7 @@ B<http://www.ethereal.com>.
Senthil Kumar Nagappan <sknagappan [AT] yahoo.com>
Jason House <jhouse [AT] mitre.org>
Peter Fales <psfales [AT] lucent.com>
Fritz Budiyanto <fritzb88 [AT] yahoo.com>
Alain Magloire <alainm[AT]rcsm.ece.mcgill.ca> was kind enough to give his
permission to use his version of snprintf.c.

View File

@ -4,7 +4,7 @@
* Copyright 2001, Michal Melerowicz <michal.melerowicz@nokia.com>
* Nicolas Balkota <balkota@mac.com>
*
* $Id: packet-gtp.c,v 1.40 2002/10/26 06:30:41 guy Exp $
* $Id: packet-gtp.c,v 1.41 2002/11/01 05:30:45 guy Exp $
*
* Ethereal - Network traffic analyzer
* By Gerald Combs <gerald@ethereal.com>
@ -3053,7 +3053,7 @@ decode_gtp_ms_reason(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, proto_tr
}
/* GPRS: 12.15
/* GPRS: 12.15 v7.6.0, chapter 7.3.3, page 45
* UMTS: 33.015
*/
static int
@ -3061,7 +3061,7 @@ decode_gtp_tr_comm(tvbuff_t *tvb, int offset, packet_info *pinfo _U_, proto_tree
guint8 tr_command;
tr_command = tvb_get_ntohl(tvb, offset+1);
tr_command = tvb_get_guint8(tvb, offset+1);
proto_tree_add_uint(tree, gtp_version ? hf_gtpv1_tr_comm : hf_gtpv0_tr_comm, tvb, offset, 2, tr_command);