osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Qt: Remove duplicate column reset and cache invalidation 

The filterPackets method calls file.c/cf_filter_packets,
which calls rescan_packets, which sends signals when done that
eventually calls the PacketList::captureFileReadFinished

PacketList::captureFileReadFinished invalidates all the column
strings after the rescan may have updated their information
(e.g., delta time to previous displayed packet), so it is not
necessary to reset the column strings a second time explicitly
in filterPackets.

Commit 38cde83a5c added the reset
to filterPackets, but commit bbe5fc1028
added the invalidateAllColumnStrings to captureFileReadFinished
that made the prior commit unnecessary.
This commit is contained in:
John Thacker 2023-01-05 08:50:56 -05:00
parent da3a48f820
commit 0c24b0ae72
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ui/logray/logray_main_window_slots.cpp
View File

@ -288,9 +288,6 @@ void LograyMainWindow::filterPackets(QString new_filter, bool force)
} else {
emit displayFilterSuccess(false);
}
if (packet_list_) {
packet_list_->resetColumns();
}
}
void LograyMainWindow::layoutToolbars()

3
ui/qt/wireshark_main_window_slots.cpp
View File

@ -314,9 +314,6 @@ void WiresharkMainWindow::filterPackets(QString new_filter, bool force)
} else {
emit displayFilterSuccess(false);
}
if (packet_list_) {
packet_list_->resetColumns();
}
}
void WiresharkMainWindow::layoutToolbars()