osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

Fix Coverity CID 281471: Logically dead code. (addr_type can only be 1 or 2 due to the return statement in the default case) 

svn path=/trunk/; revision=48577
This commit is contained in:
Chris Maynard 2013-03-27 02:46:45 +00:00
parent 51a1e7e91e
commit 05308f904d
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
epan/dissectors/packet-gsm_a_bssmap.c
View File

@ -3787,7 +3787,7 @@ static guint16
be_aoip_trans_lay_add(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo _U_, guint32 offset, guint len _U_, gchar *add_string _U_, int string_len _U_)
{
guint32 curr_offset;
guint8 addr_type = 0;
guint8 addr_type;
guint32 rtp_ipv4_address;
guint16 rtp_port;
address rtp_dst_addr;
@ -3824,8 +3824,6 @@ be_aoip_trans_lay_add(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo _U_, g
curr_offset+=2;
switch (addr_type) {
case 0:
break;
case 1:
/* IPv4 */
rtp_dst_addr.type = AT_IPv4;
@ -3840,7 +3838,7 @@ be_aoip_trans_lay_add(tvbuff_t *tvb, proto_tree *tree, packet_info *pinfo _U_, g
break;
}
if ((!pinfo->fd->flags.visited) && rtp_port != 0 && rtp_handle && addr_type != 0) {
if ((!pinfo->fd->flags.visited) && rtp_port != 0 && rtp_handle) {
rtp_add_address(pinfo, &rtp_dst_addr, rtp_port, 0, "BSS MAP", pinfo->fd->num, FALSE, 0);
rtcp_add_address(pinfo, &rtp_dst_addr, rtp_port+1, 0, "BSS MAP", pinfo->fd->num);
}