osmith
/
wireshark
forked from osmocom/wireshark
1
0
Fork 0
Code Pull Requests Releases Wiki Activity

ssl-utils: fix a couple of uninitialized variables 

Fixed these (false-positive) warnings:

    epan/dissectors/packet-ssl-utils.c:4149:30: error: 'mac_frag' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    epan/dissectors/packet-ssl-utils.c:4149:30: error: 'mac_fraglen' may be used uninitialized in this function [-Werror=maybe-uninitialized]
         else if(tls_check_mac(decoder,ct,TLSV1_VERSION,mac_frag,mac_fraglen,mac)>= 0) {

Change-Id: I282d5d60d96953858844deeaaf2069ffed3fabca
Reviewed-on: https://code.wireshark.org/review/20793
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Michael Mann <mmann78@netscape.net>
This commit is contained in:
Chema Gonzalez 2017-03-29 15:35:23 -07:00 committed by Michael Mann
parent 732d54e6e7
commit 038679c653
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
epan/dissectors/packet-ssl-utils.c
View File

@ -3959,8 +3959,8 @@ int
ssl_decrypt_record(SslDecryptSession *ssl, SslDecoder *decoder, guint8 ct, guint16 record_version,
const guchar *in, guint16 inl, StringInfo *comp_str, StringInfo *out_str, guint *outl)
{
guint pad, worklen, uncomplen, maclen, mac_fraglen;
guint8 *mac = NULL, *mac_frag;
guint pad, worklen, uncomplen, maclen, mac_fraglen = 0;
guint8 *mac = NULL, *mac_frag = NULL;
ssl_debug_printf("ssl_decrypt_record ciphertext len %d\n", inl);
ssl_print_data("Ciphertext",in, inl);