From 017c9eff05b235fc2cc25d57b4ee0611497338fb Mon Sep 17 00:00:00 2001 From: Guy Harris Date: Wed, 16 Nov 2011 01:56:58 +0000 Subject: [PATCH] Thou shalt not use proto_tree_add_string() with an FT_BYTES field. svn path=/trunk/; revision=39873 --- epan/dissectors/packet-mysql.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/epan/dissectors/packet-mysql.c b/epan/dissectors/packet-mysql.c index 1a5ce74ea3..3abcce54d4 100644 --- a/epan/dissectors/packet-mysql.c +++ b/epan/dissectors/packet-mysql.c @@ -1447,6 +1447,7 @@ mysql_dissect_response(tvbuff_t *tvb, packet_info *pinfo, int offset, gint response_code; gint strlen; gint server_status = 0; + proto_item *ti; response_code = tvb_get_guint8(tvb, offset); @@ -1530,8 +1531,8 @@ mysql_dissect_response(tvbuff_t *tvb, packet_info *pinfo, int offset, break; default: - proto_tree_add_string(tree, hf_mysql_payload, tvb, offset, -1, - "unknown/invalid response"); + ti = proto_tree_add_item(tree, hf_mysql_payload, tvb, offset, -1, ENC_NA); + expert_add_info_format(pinfo, ti, PI_UNDECODED, PI_WARN, "unknown/invalid response"); offset += tvb_reported_length_remaining(tvb, offset); conn_data->state = UNDEFINED; }