strongswan/src
Shmulik Ladkani 71b22c250f vici: Fix wrong argument order for terminate_ike() in clear_start_action()
In 7b7290977 ("controller: Add option to force destruction of an IKE_SA")
the 'force' option was added as 3rd parameter to controller_t::terminate_ike.

However in vici's 'clear_start_action', the argument was incorrectly
placed as the 2nd parameter - constantly sending 0 (FALSE) as the
'unique_id' to terminate, rendering calls to 'handle_start_actions'
having undo=TRUE being unable to terminate the relevant conn.

For example, this is log of such a bogus 'unload-conn':

  strongswan[498]: 13[CFG] vici client 96 requests: unload-conn
  strongswan[498]: 13[CFG] closing IKE_SA #9
  strongswan[498]: 13[IKE] unable to terminate IKE_SA: ID 0 not found
  strongswan[498]: 09[CFG] vici client 96 disconnected

here, the unloaded conn's IKE id was 9, alas 'terminate_ike_execute'
reports failure to terminate "ID 0".

Fix by passing 'id, FALSE' arguments in the correct order.

Fixes: 7b7290977 ("controller: Add option to force destruction of an IKE_SA")
Signed-off-by: Shmulik Ladkani <shmulik@metanetworks.com>
Closes strongswan/strongswan#127.
2019-02-19 17:00:11 +01:00
..
_copyright Remove useless break statements 2018-11-12 17:36:22 +01:00
_updown _updown: Remove printf calls for identities 2018-04-12 15:17:24 +02:00
aikgen aikgen: Fix computation of key ID of the AIK public key 2016-06-30 12:56:41 +02:00
charon Allow charon to change group on files before dropping caps 2018-06-12 10:25:30 +02:00
charon-cmd charon-cmd: Register atexit() handler for libcharon_deinit twice 2018-12-07 10:30:08 +01:00
charon-nm charon-nm: Parse any type of private key in need_secrets 2018-07-09 12:21:43 +02:00
charon-svc daemon: Use separate method to set default loggers 2017-01-25 14:58:09 +01:00
charon-systemd charon-systemd: Don't use atexit() to deinitialize the daemon 2018-11-21 14:31:49 +01:00
charon-tkm keymat_v2: Add support for PPKs 2018-09-10 18:03:01 +02:00
checksum Unify format of HSR copyright statements 2018-05-23 16:32:53 +02:00
conftest conftest: Sanity check for proposal number modifier 2018-11-12 17:36:22 +01:00
frontends signature-params: Provide option for maximum RSA/PSS salt length 2018-10-26 09:03:26 +02:00
include kernel-netlink: Add support for setting mark/mask an SA should apply to processed traffic 2018-08-31 12:24:30 +02:00
ipsec Fixed some typos, courtesy of codespell 2018-09-17 18:51:44 +02:00
libcharon vici: Fix wrong argument order for terminate_ike() in clear_start_action() 2019-02-19 17:00:11 +01:00
libfast Fixed some typos, courtesy of codespell 2018-09-17 18:51:44 +02:00
libimcv libimcv: Add Debian 9.7 to IMV database 2019-01-30 12:26:19 +01:00
libipsec Unify format of HSR copyright statements 2018-05-23 16:32:53 +02:00
libpttls Remove useless break statements 2018-11-12 17:36:22 +01:00
libradius Unify format of HSR copyright statements 2018-05-23 16:32:53 +02:00
libsimaka Unify format of HSR copyright statements 2018-05-23 16:32:53 +02:00
libstrongswan unit-tests: Verify that E and emailAddress result in the same ID 2019-01-18 11:15:16 +01:00
libtls Fixed some typos, courtesy of codespell 2018-09-17 18:51:44 +02:00
libtnccs tnccs-20: Defer handshake retry when sending SRETRY batch 2018-08-01 15:44:49 +02:00
libtncif SWIMA attribute name changes 2017-09-26 20:35:39 +02:00
libtpmtss libtpmtss: Read RSA public key exponent instead of assuming its value 2019-01-21 11:52:08 +01:00
manager manager: Restore direct return if database URI is not defined 2018-09-17 18:51:42 +02:00
medsrv Unify format of HSR copyright statements 2018-05-23 16:32:53 +02:00
pki signature-params: Provide option for maximum RSA/PSS salt length 2018-10-26 09:03:26 +02:00
pool Remove useless break statements 2018-11-12 17:36:22 +01:00
pt-tls-client pt-tls-client: Fixed man page 2018-11-20 09:53:18 +01:00
scepclient scepclient: Don't use a block-scope buffer for the default DN 2018-12-03 11:54:05 +01:00
sec-updater sec-updater.sh: Support of Debian 9.0 and Ubuntu 18.04 2018-10-07 10:14:20 +02:00
starter Avoid inclusion of unistd.h in generated lexers 2018-11-22 11:17:35 +01:00
stroke Unify format of HSR copyright statements 2018-05-23 16:32:53 +02:00
sw-collector Remove useless break statements 2018-11-12 17:36:22 +01:00
swanctl swanctl: Make credential directories relative to swanctl.conf 2018-12-14 09:11:14 +01:00
tpm_extendpcr tpm_extendpcr: Extend digests into a TPM PCR 2017-12-13 07:10:28 +01:00
Makefile.am dumm: Remove the Dynamic UML Mesh Modeler framework 2018-09-12 15:53:55 +02:00