Tobias Brunner
c0976a5e01
ike-rekey: Respond with TEMPORARY_FAILURE if we are deleting the SA
2016-06-17 18:48:05 +02:00
Tobias Brunner
72c295df5b
unit-tests: Add tests for IKE SA deletion
2016-06-17 18:48:05 +02:00
Tobias Brunner
78e8152d01
ike-delete: No need to wait for a response in case of concurrent deletes
...
RFC 7296 explicitly says we SHOULD reply as usual and forget about our
own close request.
2016-06-17 18:48:05 +02:00
Tobias Brunner
40d9a4c892
unit-tests: Only deliver messages to the SA they are addressed to
2016-06-17 18:48:05 +02:00
Tobias Brunner
498a46d22f
unit-tests: Add test for simple IKE rekey collision
2016-06-17 18:48:05 +02:00
Tobias Brunner
bb3899739d
ikev2: Add a new state to track rekeyed IKE_SAs
...
This makes handling such IKE_SAs more specifically compared to keeping them
in state IKE_CONNECTING or IKE_ESTABLISHED (which we did when we lost a
collision - even triggering the ike_updown event), or using IKE_REKEYING for
them, which would also be ambiguous.
For instance, we can now reject anything but DELETES for such SAs.
2016-06-17 18:48:05 +02:00
Tobias Brunner
d6ac7496e6
ike-rekey: Add the name/ID of the redundant IKE_SAs to the log messages
2016-06-17 18:48:04 +02:00
Tobias Brunner
b5695bbffc
unit-tests: Add tests for IKE_SA rekeying
2016-06-17 18:48:04 +02:00
Tobias Brunner
d7b3ee6cca
unit-tests: Add asserts against IKE_SAs
2016-06-17 18:48:04 +02:00
Tobias Brunner
735bd4ca14
unit-tests: Make sure to flush the IKE_SA manager before destroying the sender
...
As the static plugin that creates and destroys the default sender was
not initialized because of the missing socket the daemon won't destroy
our sender. Test cases will eventually have to flush the IKE_SA manager to
satisfy the leak detective. However, in case of a test failure and if there
are IKE_SAs in the manager the daemon will flush the SAs when deinitializing,
which will cause deletes to get sent. This crashes if the sender is already
destroyed.
2016-06-17 18:48:04 +02:00
Tobias Brunner
b76c1decd4
unit-tests: Return status from process_message()
2016-06-17 18:48:04 +02:00
Tobias Brunner
7c6e0c2979
unit-tests: Use wrapper for add_listener in bus_t related asserts
2016-06-17 18:48:04 +02:00
Tobias Brunner
5d10ef316d
unit-tests: Provide a wrapper around bus_t::add_listener and unregister them during cleanup
...
In case listeners on the stack are triggered while cleaning up after a
test failed (e.g. via ike_sa_manager_t::flush) remaining listeners defined on
the stack would cause a segmentation fault.
2016-06-17 18:48:04 +02:00
Tobias Brunner
b7fac1d96e
ike-sa-manager: Make sure rng is defined before destroying it in flush()
...
This allows calling flush() multiple times.
2016-06-17 18:48:04 +02:00
Tobias Brunner
851ee4eeb7
ike-rekey: Establish new IKE_SA earlier as responder, but only if no collision
...
Moving to the new SA only after receiving the DELETE for the old SA was
not ideal as it rendered the new SA unusable (because it simply didn't
exist in the manager) if the DELETE was delayed/got dropped.
2016-06-17 18:48:04 +02:00
Tobias Brunner
b6a3c444e4
unit-tests: Add tests where a peer is not aware of a CHILD_SA rekey collision
2016-06-17 18:48:04 +02:00
Tobias Brunner
7a23226c32
child-delete: Check if the deleted CHILD_SA is the redundant SA of a collision
...
This happens if the peer deletes the redundant SA before we are able to
handle the response. The deleted SA will be in state CHILD_INSTALLED but
we don't want to trigger the child_updown() event for it or recreate it.
2016-06-17 18:48:04 +02:00
Tobias Brunner
4f1012b3e1
child-rekey: Add method to check for the redundant SA created in a collision
2016-06-17 18:48:04 +02:00
Tobias Brunner
f97bac5594
unit-tests: Test for rekeying if INVALID_KE_PAYLOAD notifies are received
2016-06-17 18:48:03 +02:00
Tobias Brunner
5ef033c53b
child-rekey: Don't change state to INSTALLED if it was already REKEYING
...
This happens if there is a rekey collision and the peers disagree on the
DH group.
2016-06-17 18:48:03 +02:00
Tobias Brunner
557e262f04
unit-tests: Make IKE and ESP proposals configurable
2016-06-17 18:48:03 +02:00
Tobias Brunner
42af3b4cce
unit-tests: Add tests for CHILD_SA rekeying/deletion collisions
2016-06-17 18:48:03 +02:00
Tobias Brunner
62a2567b06
unit-tests: Add asserts against job scheduling
2016-06-17 18:48:03 +02:00
Tobias Brunner
cdbf942889
ikev2: Use CHILD_REKEYED for replaced CHILD_SAs after rekeying
...
This allows handling collisions better, in particular with deletions.
2016-06-17 18:48:03 +02:00
Tobias Brunner
b79beba518
unit-tests: Add asserts against task queues of IKE_SAs
2016-06-17 18:48:03 +02:00
Tobias Brunner
5bbb9d703c
child-rekey: Use more appropriate error notifies if CHILD_SA is not found or getting deleted
...
These are the notifies we should return according to RFC 7296.
2016-06-17 18:48:02 +02:00
Tobias Brunner
334b0bc84a
child-rekey: Recreate the CHILD_SA if we receive a CHILD_SA_NOT_FOUND notify
2016-06-17 18:48:02 +02:00
Tobias Brunner
b7b414463d
child-create: Handle TEMPORARY_FAILURE notify as failure
...
We will later add code to retry creating the CHILD_SA if we are not
rekeying. Rekeying is already rescheduled as with any other errors.
2016-06-17 18:48:02 +02:00
Tobias Brunner
fa098aa97c
unit-tests: Add unit tests for basic CHILD_SA rekeying
2016-06-17 18:48:02 +02:00
Tobias Brunner
14588d99a4
unit-tests: Add asserts against ike|child_rekey hooks
2016-06-17 18:48:02 +02:00
Tobias Brunner
5d7f03dcaa
unit-tests: Match in and outbound SPIs in SA asserts
...
Since we use unique sequential SPIs that should be OK.
2016-06-17 18:48:02 +02:00
Tobias Brunner
dda5aab0f4
unit-tests: Register nonce generator and make first nonce byte configurable
2016-06-17 18:48:02 +02:00
Tobias Brunner
990c62cdcc
crypto-factory: Stop after successfully creating one nonce generator
...
Fixes: e2fc09c186
("Add nonce generator interface")
2016-06-17 18:48:02 +02:00
Tobias Brunner
c1289eb578
unit-tests: Add mock nonce generator
...
We don't make the full nonces configurable but only the first byte,
which should be enough to force a nonce to be smaller than others.
2016-06-17 18:48:02 +02:00
Tobias Brunner
fbb0b3cb0a
unit-tests: Make message asserts more flexible
2016-06-17 18:48:02 +02:00
Tobias Brunner
32cfe1e00c
unit-tests: Add another CHILD_SA delete collision
2016-06-17 18:48:02 +02:00
Tobias Brunner
7e5424868d
unit-tests: Register mock DH implementation as static plugin feature
2016-06-17 18:48:02 +02:00
Tobias Brunner
1f73a74be0
unit-tests: Add mock DH implementation that's basically a noop
...
If the openssl plugin is built DH isn't that much of an overhead as
ecp256 is used, but the default MODP group is now modp3072.
2016-06-17 18:48:01 +02:00
Tobias Brunner
29f1637b9a
unit-tests: Make IKE SPIs predictable
2016-06-17 18:48:01 +02:00
Tobias Brunner
5d97e5c30f
unit-tests: Call methods on IKE_SAs in their context
2016-06-17 18:48:01 +02:00
Tobias Brunner
33e2620b8c
unit-tests: Add a unit test for CHILD_SA DELETE collisions
2016-06-17 18:48:01 +02:00
Tobias Brunner
94012e3f42
child-delete: Remove unnecessary call to destroy_child_sa()
...
Generally, we will not find the CHILD_SA by searching for it with the
outbound SPI (the initiator of the DELETE sent its inbound SPI) - and if
we found a CHILD_SA it would most likely be the wrong one (one in which
we used the same inbound SPI as the peer used for the one it deletes).
And we don't actually want to destroy the CHILD_SA at this point as we
know we already initiated a DELETE ourselves, which means that task
still has a reference to it and will destroy the CHILD_SA when it
receives the response from the other peer.
2016-06-17 18:48:01 +02:00
Tobias Brunner
632ba2a21e
unit-tests: Add asserts against hooks on listener_t and messages captured there
2016-06-17 18:48:01 +02:00
Tobias Brunner
735b0cdd01
unit-tests: Add asserts against SAs (e.g. their states)
2016-06-17 18:48:01 +02:00
Tobias Brunner
d3c4d55391
unit-tests: Add separate test runner to test IKEv2 exchanges
...
This allows proper initialization of the daemon and the helper object.
2016-06-17 18:48:01 +02:00
Tobias Brunner
c7f5259cde
unit-tests: Add helper class/object to test IKE exchanges
2016-06-17 18:48:01 +02:00
Tobias Brunner
7a5dd544f6
unit-tests: Add mock kernel_ipsec_t implementation for unit tests
...
Provides predictable sequential SPIs.
2016-06-17 18:48:01 +02:00
Tobias Brunner
87539617f1
unit-tests: Add mock sender_t implementation for unit testing
...
This allows to retrieve packets sent by an IKE_SA and pass it to another
IKE_SA directly via process_message().
2016-06-17 18:48:01 +02:00
Tobias Brunner
b104b2a737
unit-tests: Defining TESTS_RUNNERS allows to only run specific test runners
2016-06-17 18:48:01 +02:00
Tobias Brunner
3b50e6fc3e
unit-tests: Don't unload plugins before calling libcharon_deinit()
...
libcharon_deinit() already calls all the functions we called manually.
Unloading the plugins will not work if charon->initialize() is called
as charon's static plugin features would already be unloaded before the
destroyed members are accessed in destroy() to flush them.
2016-06-17 18:48:01 +02:00