ims-volte-vowifi
/
strongswan
9
0
Fork 0
Code Pull Requests Releases Activity

Don't clone chunk in message.get_packet_data

This commit is contained in:
Martin Willi 2011-11-18 17:49:53 +01:00
parent 31fc14e394
commit c311d22d0f
4 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/conftest/hooks/pretend_auth.c
View File

@ -135,7 +135,7 @@ static void process_auth_request(private_pretend_auth_t *this,
static void process_init_response(private_pretend_auth_t *this,
ike_sa_t *ike_sa, message_t *message)
{
this->ike_init = message->get_packet_data(message);
this->ike_init = chunk_clone(message->get_packet_data(message));
}
/**

2
src/libcharon/encoding/message.c
View File

@ -1404,7 +1404,7 @@ METHOD(message_t, get_packet_data, chunk_t,
{
return chunk_empty;
}
return chunk_clone(this->packet->get_data(this->packet));
return this->packet->get_data(this->packet);
}
METHOD(message_t, parse_header, status_t,

4
src/libcharon/encoding/message.h
View File

@ -344,9 +344,9 @@ struct message_t {
packet_t * (*get_packet) (message_t *this);
/**
* Returns a clone of the internal stored packet_t data.
* Returns a chunk pointing to internal packet_t data.
*
* @return clone of the internal stored packet_t data.
* @return packet data.
*/
chunk_t (*get_packet_data) (message_t *this);

7
src/libcharon/sa/ike_sa_manager.c
View File

@ -1004,11 +1004,10 @@ METHOD(ike_sa_manager_t, checkout_by_message, ike_sa_t*,
if (is_init && this->hasher)
{
/* First request. Check for an IKE_SA with such a message hash. */
chunk_t data, hash;
chunk_t hash;
data = message->get_packet_data(message);
this->hasher->allocate_hash(this->hasher, data, &hash);
chunk_free(&data);
this->hasher->allocate_hash(this->hasher,
message->get_packet_data(message), &hash);
if (get_entry_by_hash(this, id, hash, &entry, &segment) == SUCCESS)
{