From 87e53819a6dd6c788fc74f4d9157a987766b6682 Mon Sep 17 00:00:00 2001 From: Martin Willi Date: Tue, 11 Mar 2014 19:02:16 +0100 Subject: [PATCH] pki: Check length of commands array before accessing command in --help As --help is counted as command as well, the array is not null-terminated and we have to check for MAX_COMMANDS. Fixes #550. --- src/pki/command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pki/command.c b/src/pki/command.c index b6966ee0b..c2e0a5d0a 100644 --- a/src/pki/command.c +++ b/src/pki/command.c @@ -200,7 +200,7 @@ int command_usage(char *error) fprintf(out, "usage:\n"); if (active == help_idx) { - for (i = 0; cmds[i].cmd; i++) + for (i = 0; i < MAX_COMMANDS && cmds[i].cmd; i++) { fprintf(out, " pki --%-7s (-%c) %s\n", cmds[i].cmd, cmds[i].op, cmds[i].description);