From 7fd21d1fe5d14a9f762bb4a984c56b9964d1d0aa Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Fri, 9 Feb 2024 20:28:48 +0100 Subject: [PATCH] osmo-epdg: Add more debug outputs --- src/libcharon/plugins/osmo_epdg/gsup_client.c | 12 +++++++----- src/libcharon/plugins/osmo_epdg/osmo_epdg_provider.c | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/libcharon/plugins/osmo_epdg/gsup_client.c b/src/libcharon/plugins/osmo_epdg/gsup_client.c index 4fa628573..f7ff474fb 100644 --- a/src/libcharon/plugins/osmo_epdg/gsup_client.c +++ b/src/libcharon/plugins/osmo_epdg/gsup_client.c @@ -263,7 +263,7 @@ METHOD(osmo_epdg_gsup_client_t, send_auth_request, osmo_epdg_gsup_response_t*, size_t apn_enc_len = 0; int ret; - DBG1(DBG_NET, "Send Auth Request for %s", imsi); + DBG1(DBG_NET, "GSUP: Send Auth Request for %s", imsi); gsup_msg.message_type = OSMO_GSUP_MSGT_SEND_AUTH_INFO_REQUEST; gsup_msg.message_class = OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG; gsup_msg.num_auth_vectors = 1; @@ -272,12 +272,13 @@ METHOD(osmo_epdg_gsup_client_t, send_auth_request, osmo_epdg_gsup_response_t*, if (imsi_copy(gsup_msg.imsi, imsi)) { /* TODO: inval imsi! */ + DBG1(DBG_NET, "GSUP: SAR: Invalid IMSI."); return NULL; } if (!apn || strlen(apn) == 0) { - /* TODO: inval apn! */ + DBG1(DBG_NET, "GSUP: SAR: Invalid APN."); return NULL; } @@ -291,7 +292,7 @@ METHOD(osmo_epdg_gsup_client_t, send_auth_request, osmo_epdg_gsup_response_t*, gsup_msg.cn_domain = cn_domain; break; default: - DBG1(DBG_NET, "GSUP: SAIR: Ignoring invalid cn_domain message."); + DBG1(DBG_NET, "GSUP: SAR: Ignoring invalid cn_domain message."); break; } @@ -325,7 +326,7 @@ METHOD(osmo_epdg_gsup_client_t, send_auth_request, osmo_epdg_gsup_response_t*, ret = osmo_apn_from_str(apn_enc, APN_MAXLEN, apn); if (ret < 0) { - DBG1(DBG_NET, "Couldn't encode APN %s!", apn); + DBG1(DBG_NET, "GSUP: Couldn't encode APN %s!", apn); return NULL; } apn_enc_len = ret; @@ -336,7 +337,7 @@ METHOD(osmo_epdg_gsup_client_t, send_auth_request, osmo_epdg_gsup_response_t*, msg = encode_to_msgb(&gsup_msg); if (!msg) { - DBG1(DBG_NET, "Couldn't alloc/encode gsup message."); + DBG1(DBG_NET, "GSUP: Couldn't alloc/encode gsup message."); return NULL; } @@ -345,6 +346,7 @@ METHOD(osmo_epdg_gsup_client_t, send_auth_request, osmo_epdg_gsup_response_t*, timedout = enqueue(this, req, 5000); if (timedout) { + DBG1(DBG_NET, "GSUP: Timeout request."); gsup_request_destroy(this, req); return NULL; } diff --git a/src/libcharon/plugins/osmo_epdg/osmo_epdg_provider.c b/src/libcharon/plugins/osmo_epdg/osmo_epdg_provider.c index 85ca7ba8a..487ef923d 100644 --- a/src/libcharon/plugins/osmo_epdg/osmo_epdg_provider.c +++ b/src/libcharon/plugins/osmo_epdg/osmo_epdg_provider.c @@ -100,6 +100,7 @@ METHOD(simaka_provider_t, get_quintuplet, bool, this->gsup, imsi, OSMO_GSUP_CN_DOMAIN_PS, NULL, NULL, apn, PDP_TYPE_N_IETF_IPv4); if (!resp) { + DBG1(DBG_NET, "epdg_provider: Failed to send auth request."); return FALSE; }