From 39f114fd95110680f83aab7fc8ce063dc0bed0ed Mon Sep 17 00:00:00 2001 From: Alexander Couzens Date: Sat, 17 Feb 2024 01:40:45 +0100 Subject: [PATCH] osmo-epdg: UE: use .refcount = 1 instead of ref_get() in the constructor --- src/libcharon/plugins/osmo_epdg/osmo_epdg_db.c | 2 +- src/libcharon/plugins/osmo_epdg/osmo_epdg_ue.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcharon/plugins/osmo_epdg/osmo_epdg_db.c b/src/libcharon/plugins/osmo_epdg/osmo_epdg_db.c index c8eaf88f5..3f6fcf08b 100644 --- a/src/libcharon/plugins/osmo_epdg/osmo_epdg_db.c +++ b/src/libcharon/plugins/osmo_epdg/osmo_epdg_db.c @@ -77,8 +77,8 @@ METHOD(osmo_epdg_db_t, create_subscriber, osmo_epdg_ue_t *, return NULL; } + /* UE comes with refcount = 1 */ this->subscribers_imsi->put(this->subscribers_imsi, ue->get_imsi(ue), ue); - ue->get(ue); this->lock->unlock(this->lock); return ue; diff --git a/src/libcharon/plugins/osmo_epdg/osmo_epdg_ue.c b/src/libcharon/plugins/osmo_epdg/osmo_epdg_ue.c index bf221c413..02cac748e 100644 --- a/src/libcharon/plugins/osmo_epdg/osmo_epdg_ue.c +++ b/src/libcharon/plugins/osmo_epdg/osmo_epdg_ue.c @@ -162,8 +162,8 @@ osmo_epdg_ue_t *osmo_epdg_ue_create(uint32_t id, char *imsi) .id = id, .lock = rwlock_create(RWLOCK_TYPE_DEFAULT), .state = UE_WAIT_LOCATION_UPDATE, + .refcount = 1, ); - ref_get(&this->refcount); return &this->public; }