ims-volte-vowifi
/
strongswan
9
0
Fork 0
Code Pull Requests Releases Activity

imv-scanner: Properly check snprintf() return value

This commit is contained in:
Tobias Brunner 2013-07-24 10:45:32 +02:00
parent 16748bdff7
commit 346a4a1fc2
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/libimcv/plugins/imv_scanner/imv_scanner_agent.c
View File

@ -332,7 +332,8 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
u_int16_t port;
bool closed_port_policy, blocked, first;
char result_str[BUF_LEN], *pos, *protocol_str;
size_t len, written;
size_t len;
int written;
linked_list_t *port_list;
enumerator_t *e1, *e2;
@ -410,12 +411,15 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
{
written = snprintf(pos, len, "violating %s ports:",
protocol_str);
pos += written;
len -= written;
if (written > 0 && written < len)
{
pos += written;
len -= written;
}
first = FALSE;
}
written = snprintf(pos, len, " %u", port);
if (written > len || written < 0)
if (written < 0 || written >= len)
{
pos += len - 1;
*pos = '\0';
@ -503,7 +507,7 @@ imv_agent_if_t *imv_scanner_agent_create(const char *name, TNC_IMVID id,
{
return NULL;
}
INIT(this,
.public = {
.bind_functions = _bind_functions,