From c7697b62a6f590cf729a8ea0f58e4139ba60ad42 Mon Sep 17 00:00:00 2001
From: Francisco Paisana <francisco.paisana@softwareradiosystems.com>
Date: Thu, 22 Oct 2020 10:28:44 +0100
Subject: [PATCH] fix asn1_utils_test. arrays used for equal comparison where
 not being initialized.

---
 lib/test/asn1/asn1_utils_test.cc | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/lib/test/asn1/asn1_utils_test.cc b/lib/test/asn1/asn1_utils_test.cc
index c8ffc1918..6952d38a6 100644
--- a/lib/test/asn1/asn1_utils_test.cc
+++ b/lib/test/asn1/asn1_utils_test.cc
@@ -21,10 +21,15 @@ and at http://www.gnu.org/licenses/.
 #include "srslte/asn1/asn1_utils.h"
 #include "srslte/common/test_common.h"
 #include <cmath>
+#include <numeric>
+#include <random>
 
 using namespace std;
 using namespace asn1;
 
+std::random_device rd;
+std::mt19937       g(rd());
+
 int test_arrays()
 {
   /* Test Ext Array */
@@ -443,9 +448,13 @@ int test_seq_of()
 
   // dynamic array
   dyn_array<int> vec, vec2(33);
+  std::iota(vec2.begin(), vec2.end(), 0);
+  std::shuffle(vec2.begin(), vec2.end(), g);
   TESTASSERT(vec2.size() == 33);
   TESTASSERT(vec.size() == 0);
   vec.resize(32);
+  std::iota(vec.begin(), vec.end(), 0);
+  std::shuffle(vec.begin(), vec.end(), g);
   TESTASSERT(vec.size() == 32);
   vec[5] = 5;
   vec.push_back(33);
@@ -458,10 +467,10 @@ int test_seq_of()
   {
     dyn_array<int> vec3 = vec2;
     TESTASSERT(vec3.size() == vec2.size());
-    TESTASSERT(std::equal(&vec3[0], &vec3.back(), &vec2[0]));
+    TESTASSERT(std::equal(vec3.begin(), vec3.end(), vec2.begin()));
     vec3 = vec;
     TESTASSERT(vec3.size() == vec.size());
-    TESTASSERT(std::equal(&vec3[0], &vec3.back(), &vec[0]));
+    TESTASSERT(std::equal(vec3.begin(), vec3.end(), vec.begin()));
   }
   TESTASSERT(vec[5] == 5);