From 051522924031d83347dc1485891ebfda5bf295bb Mon Sep 17 00:00:00 2001 From: Francisco Paisana Date: Mon, 11 May 2020 12:23:35 +0100 Subject: [PATCH] perform mac bearer addiction via the bearer handler class --- srsenb/hdr/stack/rrc/rrc.h | 18 --- srsenb/hdr/stack/rrc/rrc_ue.h | 33 +++-- srsenb/src/stack/rrc/rrc.cc | 208 ++------------------------- srsenb/src/stack/rrc/rrc_mobility.cc | 20 +-- srsenb/src/stack/rrc/rrc_ue.cc | 78 ++++++++-- 5 files changed, 114 insertions(+), 243 deletions(-) diff --git a/srsenb/hdr/stack/rrc/rrc.h b/srsenb/hdr/stack/rrc/rrc.h index e186f98d1..a3b1a97eb 100644 --- a/srsenb/hdr/stack/rrc/rrc.h +++ b/srsenb/hdr/stack/rrc/rrc.h @@ -156,11 +156,6 @@ private: bool setup_erabs(const asn1::s1ap::erab_to_be_setup_list_ctxt_su_req_l& e); bool setup_erabs(const asn1::s1ap::erab_to_be_setup_list_bearer_su_req_l& e); - void setup_erab(uint8_t id, - const asn1::s1ap::erab_level_qos_params_s& qos, - const asn1::bounded_bitstring<1, 160, true, true>& addr, - uint32_t teid_out, - const asn1::unbounded_octstring* nas_pdu); bool release_erabs(); // handover @@ -221,24 +216,11 @@ private: asn1::rrc::ue_eutra_cap_s eutra_capabilities; srslte::rrc_ue_capabilities_t ue_capabilities; - struct erab_t { - uint8_t id; - asn1::s1ap::erab_level_qos_params_s qos_params; - asn1::bounded_bitstring<1, 160, true, true> address; - uint32_t teid_out; - uint32_t teid_in; - }; - std::map erabs; - - std::map erab_info_list; - const static uint32_t UE_PCELL_CC_IDX = 0; cell_ctxt_dedicated_list cell_ded_list; bearer_handler bearer_list; - int get_drbid_config(asn1::rrc::drb_to_add_mod_s* drb, int drbid); - ///< Helper to access a cell cfg based on ue_cc_idx cell_info_common* get_ue_cc_cfg(uint32_t ue_cc_idx); diff --git a/srsenb/hdr/stack/rrc/rrc_ue.h b/srsenb/hdr/stack/rrc/rrc_ue.h index 47c33f341..01e240a36 100644 --- a/srsenb/hdr/stack/rrc/rrc_ue.h +++ b/srsenb/hdr/stack/rrc/rrc_ue.h @@ -40,11 +40,13 @@ public: uint32_t teid_in; }; - bearer_handler(uint16_t rnti_, - const rrc_cfg_t& cfg_, - pdcp_interface_rrc* pdcp_, - rlc_interface_rrc* rlc_, - gtpu_interface_rrc* gtpu_); + bearer_handler(uint16_t rnti_, + const rrc_cfg_t& cfg_, + pdcp_interface_rrc* pdcp_, + rlc_interface_rrc* rlc_, + mac_interface_rrc* mac_, + gtpu_interface_rrc* gtpu_, + sched_interface::ue_cfg_t& ue_cfg_); void setup_srb(uint8_t srb_id); int setup_erab(uint8_t id, @@ -52,22 +54,29 @@ public: const asn1::bounded_bitstring<1, 160, true, true>& addr, uint32_t teid_out, const asn1::unbounded_octstring* nas_pdu); + void release_erab(uint8_t erab_id); + void release_erabs(); void handle_rrc_setup(asn1::rrc::rrc_conn_setup_r8_ies_s* msg); void handle_rrc_reest(asn1::rrc::rrc_conn_reest_r8_ies_s* msg); void handle_rrc_reconf(asn1::rrc::rrc_conn_recfg_r8_ies_s* msg); + void handle_rrc_reconf_complete(); + + const std::map& get_erabs() const { return erabs; } private: void fill_and_apply_bearer_updates(asn1::rrc::rr_cfg_ded_s& msg); void fill_pending_nas_info(asn1::rrc::rrc_conn_recfg_r8_ies_s* msg); - srslte::log_ref log_h{"RRC"}; - uint16_t rnti; - const rrc_cfg_t* cfg; - pdcp_interface_rrc* pdcp; - rlc_interface_rrc* rlc; - gtpu_interface_rrc* gtpu; - srslte::byte_buffer_pool* pool = nullptr; + srslte::log_ref log_h{"RRC"}; + uint16_t rnti; + const rrc_cfg_t* cfg; + pdcp_interface_rrc* pdcp; + rlc_interface_rrc* rlc; + mac_interface_rrc* mac; + gtpu_interface_rrc* gtpu; + sched_interface::ue_cfg_t* sched_ue_cfg; + srslte::byte_buffer_pool* pool = nullptr; std::map erab_info_list; std::map erabs; diff --git a/srsenb/src/stack/rrc/rrc.cc b/srsenb/src/stack/rrc/rrc.cc index 029b0f9c7..e9488a9a8 100644 --- a/srsenb/src/stack/rrc/rrc.cc +++ b/srsenb/src/stack/rrc/rrc.cc @@ -974,7 +974,7 @@ rrc::ue::ue(rrc* outer_rrc, uint16_t rnti_, const sched_interface::ue_cfg_t& sch current_sched_ue_cfg(sched_ue_cfg), phy_rrc_dedicated_list(sched_ue_cfg.supported_cc_list.size()), cell_ded_list(parent->cfg, *outer_rrc->pucch_res_list, *outer_rrc->cell_common_list), - bearer_list(rnti_, parent->cfg, parent->pdcp, parent->rlc, parent->gtpu) + bearer_list(rnti_, parent->cfg, parent->pdcp, parent->rlc, parent->mac, parent->gtpu, current_sched_ue_cfg) { if (current_sched_ue_cfg.supported_cc_list.empty() or not current_sched_ue_cfg.supported_cc_list[0].active) { parent->rrc_log->warning("No PCell set. Picking eNBccIdx=0 as PCell\n"); @@ -1228,24 +1228,7 @@ void rrc::ue::handle_rrc_reconf_complete(rrc_conn_recfg_complete_s* msg, srslte: } parent->mac->ue_cfg(rnti, ¤t_sched_ue_cfg); - // Finally, add SRB2 and DRB1 and any dedicated DRBs to the scheduler - srsenb::sched_interface::ue_bearer_cfg_t bearer_cfg = {}; - bearer_cfg.direction = srsenb::sched_interface::ue_bearer_cfg_t::BOTH; - bearer_cfg.group = 0; - parent->mac->bearer_ue_cfg(rnti, 2, &bearer_cfg); - current_sched_ue_cfg.ue_bearers[2] = bearer_cfg; - - bearer_cfg.group = last_rrc_conn_recfg.crit_exts.c1() - .rrc_conn_recfg_r8() - .rr_cfg_ded.drb_to_add_mod_list[0] - .lc_ch_cfg.ul_specific_params.lc_ch_group; - for (const std::pair& erab_pair : erabs) { - parent->mac->bearer_ue_cfg(rnti, erab_pair.second.id - 2, &bearer_cfg); - current_sched_ue_cfg.ue_bearers[erab_pair.second.id - 2] = bearer_cfg; - } - - // Acknowledge Dedicated Configuration - parent->mac->phy_config_enabled(rnti, true); + bearer_list.handle_rrc_reconf_complete(); } else { parent->rrc_log->error("Expected RRCReconfigurationComplete with transaction ID: %d, got %d\n", last_rrc_conn_recfg.rrc_transaction_id, @@ -1346,7 +1329,7 @@ bool rrc::ue::setup_erabs(const asn1::s1ap::erab_to_be_setup_list_ctxt_su_req_l& uint32_t teid_out; uint8_to_uint32(erab.gtp_teid.data(), &teid_out); const asn1::unbounded_octstring* nas_pdu = erab.nas_pdu_present ? &erab.nas_pdu : nullptr; - setup_erab(erab.erab_id, erab.erab_level_qos_params, erab.transport_layer_address, teid_out, nas_pdu); + bearer_list.setup_erab(erab.erab_id, erab.erab_level_qos_params, erab.transport_layer_address, teid_out, nas_pdu); } return true; } @@ -1368,7 +1351,8 @@ bool rrc::ue::setup_erabs(const asn1::s1ap::erab_to_be_setup_list_bearer_su_req_ uint32_t teid_out; uint8_to_uint32(erab.gtp_teid.data(), &teid_out); - setup_erab(erab.erab_id, erab.erab_level_qos_params, erab.transport_layer_address, teid_out, &erab.nas_pdu); + bearer_list.setup_erab( + erab.erab_id, erab.erab_level_qos_params, erab.transport_layer_address, teid_out, &erab.nas_pdu); } // Work in progress @@ -1377,38 +1361,9 @@ bool rrc::ue::setup_erabs(const asn1::s1ap::erab_to_be_setup_list_bearer_su_req_ return true; } -void rrc::ue::setup_erab(uint8_t id, - const asn1::s1ap::erab_level_qos_params_s& qos, - const asn1::bounded_bitstring<1, 160, true, true>& addr, - uint32_t teid_out, - const asn1::unbounded_octstring* nas_pdu) -{ - erabs[id].id = id; - erabs[id].qos_params = qos; - erabs[id].address = addr; - erabs[id].teid_out = teid_out; - - if (addr.length() > 32) { - parent->rrc_log->error("Only addresses with length <= 32 are supported\n"); - return; - } - uint32_t addr_ = addr.to_number(); - uint8_t lcid = id - 2; // Map e.g. E-RAB 5 to LCID 3 (==DRB1) - parent->gtpu->add_bearer(rnti, lcid, addr_, erabs[id].teid_out, &(erabs[id].teid_in)); - - if (nas_pdu != nullptr) { - erab_info_list[id] = allocate_unique_buffer(*pool); - memcpy(erab_info_list[id]->msg, nas_pdu->data(), nas_pdu->size()); - erab_info_list[id]->N_bytes = nas_pdu->size(); - parent->rrc_log->info_hex( - erab_info_list[id]->msg, erab_info_list[id]->N_bytes, "setup_erab nas_pdu -> erab_info rnti 0x%x", rnti); - } -} - bool rrc::ue::release_erabs() { - // TODO: notify GTPU layer for each ERAB - erabs.clear(); + bearer_list.release_erabs(); return true; } @@ -1416,9 +1371,9 @@ void rrc::ue::notify_s1ap_ue_ctxt_setup_complete() { asn1::s1ap::init_context_setup_resp_s res; - res.protocol_ies.erab_setup_list_ctxt_su_res.value.resize(erabs.size()); + res.protocol_ies.erab_setup_list_ctxt_su_res.value.resize(bearer_list.get_erabs().size()); uint32_t i = 0; - for (auto& erab : erabs) { + for (const auto& erab : bearer_list.get_erabs()) { res.protocol_ies.erab_setup_list_ctxt_su_res.value[i].load_info_obj(ASN1_S1AP_ID_ERAB_SETUP_ITEM_CTXT_SU_RES); auto& item = res.protocol_ies.erab_setup_list_ctxt_su_res.value[i].value.erab_setup_item_ctxt_su_res(); item.erab_id = erab.second.id; @@ -1440,7 +1395,7 @@ void rrc::ue::notify_s1ap_ue_erab_setup_response(const asn1::s1ap::erab_to_be_se item.load_info_obj(ASN1_S1AP_ID_ERAB_SETUP_ITEM_BEARER_SU_RES); uint8_t id = e[i].value.erab_to_be_setup_item_bearer_su_req().erab_id; item.value.erab_setup_item_bearer_su_res().erab_id = id; - uint32_to_uint8(erabs[id].teid_in, &item.value.erab_setup_item_bearer_su_res().gtp_teid[0]); + uint32_to_uint8(bearer_list.get_erabs().at(id).teid_in, &item.value.erab_setup_item_bearer_su_res().gtp_teid[0]); } parent->s1ap->ue_erab_setup_complete(rnti, res); @@ -1621,43 +1576,6 @@ void rrc::ue::send_connection_release() send_dl_dcch(&dl_dcch_msg); } -int rrc::ue::get_drbid_config(drb_to_add_mod_s* drb, int drb_id) -{ - uint32_t lc_id = (uint32_t)(drb_id + 2); - uint32_t erab_id = lc_id + 2; - uint32_t qci = erabs[erab_id].qos_params.qci; - - if (qci >= MAX_NOF_QCI) { - parent->rrc_log->error("Invalid QCI=%d for ERAB_id=%d, DRB_id=%d\n", qci, erab_id, drb_id); - return SRSLTE_ERROR; - } - - if (!parent->cfg.qci_cfg[qci].configured) { - parent->rrc_log->error("QCI=%d not configured\n", qci); - return SRSLTE_ERROR; - } - - // Add DRB1 to the message - drb->drb_id = (uint8_t)drb_id; - drb->lc_ch_id_present = true; - drb->lc_ch_id = (uint8_t)lc_id; - drb->eps_bearer_id = (uint8_t)erab_id; - drb->eps_bearer_id_present = true; - - drb->lc_ch_cfg_present = true; - drb->lc_ch_cfg.ul_specific_params_present = true; - drb->lc_ch_cfg.ul_specific_params.lc_ch_group_present = true; - drb->lc_ch_cfg.ul_specific_params = parent->cfg.qci_cfg[qci].lc_cfg; - - drb->pdcp_cfg_present = true; - drb->pdcp_cfg = parent->cfg.qci_cfg[qci].pdcp_cfg; - - drb->rlc_cfg_present = true; - drb->rlc_cfg = parent->cfg.qci_cfg[qci].rlc_cfg; - - return SRSLTE_SUCCESS; -} - void rrc::ue::send_connection_reconf_upd(srslte::unique_byte_buffer_t pdu) { dl_dcch_msg_s dl_dcch_msg; @@ -1793,57 +1711,10 @@ void rrc::ue::send_connection_reconf(srslte::unique_byte_buffer_t pdu) parent->pdcp->enable_integrity(rnti, 2); parent->pdcp->enable_encryption(rnti, 2); - // Add DRB Add/Mod list - conn_reconf->rr_cfg_ded.drb_to_add_mod_list_present = true; - conn_reconf->rr_cfg_ded.drb_to_add_mod_list.resize(erabs.size()); - - // Add space for NAS messages - uint8_t n_nas = erab_info_list.size(); - if (n_nas > 0) { - conn_reconf->ded_info_nas_list_present = true; - conn_reconf->ded_info_nas_list.resize(n_nas); - } - - // Configure all DRBs - uint8_t vec_idx = 0; - for (const std::pair& erab_id_pair : erabs) { - const erab_t& erab = erab_id_pair.second; - uint8_t drb_id = erab.id - 4; - uint8_t lcid = erab.id - 2; - - // Get DRB1 configuration - if (get_drbid_config(&conn_reconf->rr_cfg_ded.drb_to_add_mod_list[drb_id - 1], drb_id)) { - parent->rrc_log->error("Getting DRB1 configuration\n"); - parent->rrc_log->console("The QCI %d for DRB1 is invalid or not configured.\n", erab.qos_params.qci); - return; - } - - // Configure DRBs in RLC - parent->rlc->add_bearer( - rnti, lcid, srslte::make_rlc_config_t(conn_reconf->rr_cfg_ded.drb_to_add_mod_list[vec_idx].rlc_cfg)); - - // Configure DRB1 in PDCP - srslte::pdcp_config_t pdcp_cnfg_drb = - srslte::make_drb_pdcp_config_t(drb_id, false, conn_reconf->rr_cfg_ded.drb_to_add_mod_list[vec_idx].pdcp_cfg); - parent->pdcp->add_bearer(rnti, lcid, pdcp_cnfg_drb); - parent->pdcp->config_security(rnti, lcid, sec_cfg); - parent->pdcp->enable_integrity(rnti, lcid); - parent->pdcp->enable_encryption(rnti, lcid); - - // DRBs have already been configured in GTPU through bearer setup - // Add E-RAB info message for the E-RABs - std::map::const_iterator it = erab_info_list.find(erab.id); - if (it != erab_info_list.end()) { - const srslte::unique_byte_buffer_t& erab_info = it->second; - parent->rrc_log->info_hex( - erab_info->msg, erab_info->N_bytes, "connection_reconf erab_info -> nas_info rnti 0x%x\n", rnti); - conn_reconf->ded_info_nas_list[vec_idx].resize(erab_info->N_bytes); - memcpy(conn_reconf->ded_info_nas_list[vec_idx].data(), erab_info->msg, erab_info->N_bytes); - erab_info_list.erase(it); - } else { - parent->rrc_log->debug("Not adding NAS message to connection reconfiguration. E-RAB id %d\n", erab.id); - } - vec_idx++; + for (const drb_to_add_mod_s& drb : conn_reconf->rr_cfg_ded.drb_to_add_mod_list) { + parent->pdcp->config_security(rnti, drb.lc_ch_id, sec_cfg); + parent->pdcp->enable_integrity(rnti, drb.lc_ch_id); + parent->pdcp->enable_encryption(rnti, drb.lc_ch_id); } if (mobility_handler != nullptr) { @@ -2031,58 +1902,7 @@ void rrc::ue::send_connection_reconf_new_bearer(const asn1::s1ap::erab_to_be_set dl_dcch_msg.msg.c1().rrc_conn_recfg().rrc_transaction_id = (uint8_t)((transaction_id++) % 4); rrc_conn_recfg_r8_ies_s* conn_reconf = &dl_dcch_msg.msg.c1().rrc_conn_recfg().crit_exts.c1().rrc_conn_recfg_r8(); - for (const auto& item : e) { - auto& erab = item.value.erab_to_be_setup_item_bearer_su_req(); - uint8_t id = erab.erab_id; - uint8_t lcid = id - 2; // Map e.g. E-RAB 5 to LCID 3 (==DRB1) - - // Get DRB configuration - drb_to_add_mod_s drb_item; - if (get_drbid_config(&drb_item, lcid - 2)) { - parent->rrc_log->error("Getting DRB configuration\n"); - parent->rrc_log->console("ERROR: The QCI %d is invalid or not configured.\n", erabs[id].qos_params.qci); - // TODO: send S1AP response indicating error? - return; - } - - // Add DRB to the scheduler - srsenb::sched_interface::ue_bearer_cfg_t bearer_cfg; - bearer_cfg.direction = srsenb::sched_interface::ue_bearer_cfg_t::BOTH; - parent->mac->bearer_ue_cfg(rnti, lcid, &bearer_cfg); - current_sched_ue_cfg.ue_bearers[lcid] = bearer_cfg; - - // Configure DRB in RLC - parent->rlc->add_bearer(rnti, lcid, srslte::make_rlc_config_t(drb_item.rlc_cfg)); - - // Configure DRB in PDCP - // TODO: Review all ID mapping LCID DRB ERAB EPSBID Mapping - if (drb_item.pdcp_cfg_present) { - parent->pdcp->add_bearer( - rnti, lcid, srslte::make_drb_pdcp_config_t(drb_item.drb_id - 1, false, drb_item.pdcp_cfg)); - } else { - // use default config - parent->pdcp->add_bearer(rnti, lcid, srslte::make_drb_pdcp_config_t(drb_item.drb_id - 1, false)); - } - - // DRB has already been configured in GTPU through bearer setup - conn_reconf->rr_cfg_ded.drb_to_add_mod_list.push_back(drb_item); - - // Add NAS message - std::map::const_iterator it = erab_info_list.find(id); - if (it != erab_info_list.end()) { - const srslte::unique_byte_buffer_t& erab_info = erab_info_list[id]; - parent->rrc_log->info_hex( - erab_info->msg, erab_info->N_bytes, "reconf_new_bearer erab_info -> nas_info rnti 0x%x\n", rnti); - asn1::dyn_octstring octstr(erab_info->N_bytes); - memcpy(octstr.data(), erab_info->msg, erab_info->N_bytes); - conn_reconf->ded_info_nas_list.push_back(octstr); - conn_reconf->ded_info_nas_list_present = true; - erab_info_list.erase(it); - } - } - conn_reconf->rr_cfg_ded_present = true; - conn_reconf->rr_cfg_ded.drb_to_add_mod_list_present = conn_reconf->rr_cfg_ded.drb_to_add_mod_list.size() > 0; - conn_reconf->ded_info_nas_list_present = conn_reconf->ded_info_nas_list.size() > 0; + bearer_list.handle_rrc_reconf(conn_reconf); send_dl_dcch(&dl_dcch_msg, std::move(pdu)); } diff --git a/srsenb/src/stack/rrc/rrc_mobility.cc b/srsenb/src/stack/rrc/rrc_mobility.cc index 6983b1de7..beeb47f9a 100644 --- a/srsenb/src/stack/rrc/rrc_mobility.cc +++ b/srsenb/src/stack/rrc/rrc_mobility.cc @@ -738,11 +738,11 @@ void rrc::ue::rrc_mobility::handle_ue_meas_report(const meas_report_s& msg) return; } - const meas_obj_to_add_mod_list_l& objs = ue_var_meas->meas_objs(); - const report_cfg_to_add_mod_list_l& reps = ue_var_meas->rep_cfgs(); - auto obj_it = rrc_details::binary_find(objs, measid_it->meas_obj_id); - auto rep_it = rrc_details::binary_find(reps, measid_it->report_cfg_id); - const meas_result_list_eutra_l& eutra_list = meas_res.meas_result_neigh_cells.meas_result_list_eutra(); + const meas_obj_to_add_mod_list_l& objs = ue_var_meas->meas_objs(); + // const report_cfg_to_add_mod_list_l& reps = ue_var_meas->rep_cfgs(); + auto obj_it = rrc_details::binary_find(objs, measid_it->meas_obj_id); + // auto rep_it = rrc_details::binary_find(reps, measid_it->report_cfg_id); + const meas_result_list_eutra_l& eutra_list = meas_res.meas_result_neigh_cells.meas_result_list_eutra(); // iterate from strongest to weakest cell // NOTE: From now we just look at the strongest. @@ -967,10 +967,10 @@ bool rrc::ue::rrc_mobility::update_ue_var_meas_cfg(const var_meas_cfg_t& source */ bool rrc::ue::rrc_mobility::start_enb_status_transfer() { - std::vector bearer_list; - bearer_list.reserve(rrc_ue->erabs.size()); + std::vector s1ap_bearers; + s1ap_bearers.reserve(rrc_ue->bearer_list.get_erabs().size()); - for (const auto& erab_pair : rrc_ue->erabs) { + for (const auto& erab_pair : rrc_ue->bearer_list.get_erabs()) { s1ap_interface_rrc::bearer_status_info b = {}; uint8_t lcid = erab_pair.second.id - 2u; b.erab_id = erab_pair.second.id; @@ -978,11 +978,11 @@ bool rrc::ue::rrc_mobility::start_enb_status_transfer() Error("PDCP bearer lcid=%d for rnti=0x%x was not found\n", lcid, rrc_ue->rnti); return false; } - bearer_list.push_back(b); + s1ap_bearers.push_back(b); } Info("PDCP Bearer list sent to S1AP to initiate the eNB Status Transfer\n"); - return rrc_enb->s1ap->send_enb_status_transfer_proc(rrc_ue->rnti, bearer_list); + return rrc_enb->s1ap->send_enb_status_transfer_proc(rrc_ue->rnti, s1ap_bearers); } /************************************************************************************************* diff --git a/srsenb/src/stack/rrc/rrc_ue.cc b/srsenb/src/stack/rrc/rrc_ue.cc index 020f029e0..365acbcc4 100644 --- a/srsenb/src/stack/rrc/rrc_ue.cc +++ b/srsenb/src/stack/rrc/rrc_ue.cc @@ -21,6 +21,7 @@ #include "srsenb/hdr/stack/rrc/rrc_ue.h" #include "srslte/asn1/rrc_asn1_utils.h" +#include "srslte/interfaces/sched_interface.h" #include "srslte/rrc/bearer_cfg.h" namespace srsenb { @@ -31,12 +32,16 @@ bearer_handler::bearer_handler(uint16_t rnti_, const rrc_cfg_t& cfg_, pdcp_interface_rrc* pdcp_, rlc_interface_rrc* rlc_, - gtpu_interface_rrc* gtpu_) : + mac_interface_rrc* mac_, + gtpu_interface_rrc* gtpu_, + sched_interface::ue_cfg_t& ue_cfg_) : rnti(rnti_), cfg(&cfg_), pdcp(pdcp_), rlc(rlc_), - gtpu(gtpu_) + mac(mac_), + gtpu(gtpu_), + sched_ue_cfg(&ue_cfg_) { pool = srslte::byte_buffer_pool::get_instance(); } @@ -110,6 +115,30 @@ int bearer_handler::setup_erab(uint8_t return SRSLTE_SUCCESS; } +void bearer_handler::release_erab(uint8_t erab_id) +{ + auto it = erabs.find(erab_id); + if (it == erabs.end()) { + log_h->warning("The user rnti=0x%x does not contain ERAB-ID=%d\n", rnti, erab_id); + return; + } + + uint8_t drb_id = erab_id - 4; + drbs_to_release.push_back(drb_id); + + erabs.erase(it); + erab_info_list.erase(erab_id); +} + +void bearer_handler::release_erabs() +{ + // TODO: notify GTPU layer for each ERAB + erabs.clear(); + while (not erabs.empty()) { + release_erab(erabs.begin()->first); + } +} + void bearer_handler::handle_rrc_setup(asn1::rrc::rrc_conn_setup_r8_ies_s* msg) { fill_and_apply_bearer_updates(msg->rr_cfg_ded); @@ -129,6 +158,37 @@ void bearer_handler::handle_rrc_reconf(asn1::rrc::rrc_conn_recfg_r8_ies_s* msg) fill_pending_nas_info(msg); } +void bearer_handler::handle_rrc_reconf_complete() +{ + // Finally, add SRB2 and DRBs and any dedicated DRBs to the scheduler + srsenb::sched_interface::ue_bearer_cfg_t bearer_cfg = {}; + for (const srb_to_add_mod_s& srb : srbs_to_add) { + bearer_cfg.direction = srsenb::sched_interface::ue_bearer_cfg_t::BOTH; + bearer_cfg.group = 0; + mac->bearer_ue_cfg(rnti, srb.srb_id, &bearer_cfg); + sched_ue_cfg->ue_bearers[srb.srb_id] = bearer_cfg; + } + for (uint8_t drb_id : drbs_to_release) { + bearer_cfg.direction = sched_interface::ue_bearer_cfg_t::IDLE; + mac->bearer_ue_cfg(rnti, drb_id + 2, &bearer_cfg); + sched_ue_cfg->ue_bearers[drb_id + 2] = bearer_cfg; + } + for (const drb_to_add_mod_s& drb : drbs_to_add) { + bearer_cfg.direction = sched_interface::ue_bearer_cfg_t::BOTH; + bearer_cfg.group = drb.lc_ch_cfg.ul_specific_params.lc_ch_group; + mac->bearer_ue_cfg(rnti, drb.lc_ch_id, &bearer_cfg); + sched_ue_cfg->ue_bearers[drb.lc_ch_id] = bearer_cfg; + } + + // Acknowledge Dedicated Configuration + mac->phy_config_enabled(rnti, true); + + // Reset ToAdd state + srbs_to_add = {}; + drbs_to_add = {}; + drbs_to_release.resize(0); +} + void bearer_handler::fill_and_apply_bearer_updates(asn1::rrc::rr_cfg_ded_s& msg) { // Add altered bearers to message @@ -164,15 +224,15 @@ void bearer_handler::fill_and_apply_bearer_updates(asn1::rrc::rr_cfg_ded_s& msg) rlc->add_bearer(rnti, drb.lc_ch_id, srslte::make_rlc_config_t(drb.rlc_cfg)); // Configure DRB1 in PDCP - srslte::pdcp_config_t pdcp_cnfg_drb = srslte::make_drb_pdcp_config_t(drb.drb_id, false, drb.pdcp_cfg); - pdcp->add_bearer(rnti, drb.lc_ch_id, pdcp_cnfg_drb); + if (drb.pdcp_cfg_present) { + srslte::pdcp_config_t pdcp_cnfg_drb = srslte::make_drb_pdcp_config_t(drb.drb_id, false, drb.pdcp_cfg); + pdcp->add_bearer(rnti, drb.lc_ch_id, pdcp_cnfg_drb); + } else { + srslte::pdcp_config_t pdcp_cnfg_drb = srslte::make_drb_pdcp_config_t(drb.drb_id, false); + pdcp->add_bearer(rnti, drb.lc_ch_id, pdcp_cnfg_drb); + } } } - - // Reset ToAdd state - srbs_to_add = {}; - drbs_to_add = {}; - drbs_to_release.resize(0); } void bearer_handler::fill_pending_nas_info(asn1::rrc::rrc_conn_recfg_r8_ies_s* msg)