Commit Graph

19 Commits

Author SHA1 Message Date
mich c61b8bc0aa mobile: fix the reset of SMS UD value 2020-06-15 09:59:10 +02:00
Benoit Michau ac85bc4db8
Merge pull request #74 from axilirator/fixeria/fixes
Fix incorrect field order in SMS_SUBMIT, SMS_DELIVER and  SMS_STATUS_REPORT TPDUs
2020-01-28 14:44:03 +01:00
mich 5b6d35d153 mobile: fix SMS with 7bit DCS user data 2020-01-28 14:41:09 +01:00
Vadim Yanitskiy 8404debca4 mobile/TS23040_SMS: fix incorrect field order in TPDUs
Unfortunately, the message format definitions of the transport layer
in subclause 9.2.2 of 3GPP TS 23.040 are ambiguous. In particular,
the order in tables defining basic elements does not match the
order defined in the message layout tables.

Most implementations including Wireshark and TTCN-3 L3 definitions
by Ericsson [1] follow the order defined the those layout tables.
For example, this is how tshark dissects an SMS-SUBMIT message:

  GSM SMS TPDU (GSM 03.40) SMS-SUBMIT
  0... .... = TP-RP: TP Reply Path parameter is not set in this SMS SUBMIT/DELIVER
  .0.. .... = TP-UDHI: The TP UD field contains only the short message
  ..1. .... = TP-SRR: A status report is requested
  ...0 0... = TP-VPF: TP-VP field not present (0)
  .... .1.. = TP-RD: Instruct SC to reject duplicates
  .... ..01 = TP-MTI: SMS-SUBMIT (1)

This order has been manually verified by sending two short messages
with and without status report request (TP-SRR) enabled. Let's also
follow the order defined in the layout tables.

[1] https://git.eclipse.org/c/titan/titan.ProtocolModules.MobileL3_v13.4.0.git/tree/src/MobileL3_SMS_Types.ttcn
2020-01-28 02:57:14 +07:00
mich 7b1271c7d1 mobile: add some specific SMS UDH structures in 23.040 2019-09-06 18:18:04 +02:00
mich f7d1adad9a mobile: add missing default values for TP-MTI in SMS TPDU 2019-09-02 15:50:27 +02:00
mich 4b70f73862 mobile: fix TP-PDI automation in SMS_SUBMIT_REPORT_RP_ERROR 2019-08-14 11:22:57 +02:00
mich 61d58e88be mobile: add a check for alphanumeric SMS numbers in TP address field 2019-07-02 17:30:00 +02:00
mich e392403aa8 mobile: add support for alphanumeric SMS numbers in TP address field 2019-07-02 17:01:22 +02:00
mich 7160a753ed making a global 0.4 tagged release 2019-02-25 11:26:10 +01:00
mich aed110a6a8 pycrate_mobile: TS23040_SMS, fix decoding of SMS_STATUS_REPORT again 2019-01-04 18:04:49 +01:00
mich ce0672a8cc pycrate_mobile: TS23040_SMS, fix decoding of SMS_STATUS_REPORT with TP_PI field which is optional 2019-01-04 18:03:31 +01:00
mich ee66b195e4 mobile: fix raw UD setting in SMS 2018-09-18 11:33:02 +02:00
mitshell 2a670f0bcc mobile: few fixes 2018-07-15 16:19:45 +02:00
mitshell ae1a34d5dc change of license: from GPL to LGPL, except for tools 2018-04-15 21:47:21 +02:00
mitshell 401e80e18c bump version to 0.3 2018-02-09 22:23:26 +01:00
mitshell e2a4fab1e3 mobile: rework NAS headers, add proper transaction id parsing, wrap all IEs into proper TypeX structures, plus few other modifications 2018-02-09 21:58:36 +01:00
mitshell 909752627b mobile: fix SMS utf-16 codec 2017-11-26 11:53:54 +01:00
mitshell 25236b0d66 mobile: remove default val, improve IE handling, add support for SMS, SS and LTE NAS 2017-11-12 15:18:50 +01:00