corenet: add more checks on the decoded PDU
This commit is contained in:
parent
c64c05ee5d
commit
6d713a1a9b
|
@ -159,7 +159,7 @@ class LinkSigProc(SigProc):
|
||||||
|
|
||||||
select the expected content in self.Cont, according to the pdu type
|
select the expected content in self.Cont, according to the pdu type
|
||||||
select the potential decoders in self.Decod
|
select the potential decoders in self.Decod
|
||||||
raise HNBAPErr if an error requiring procedure rejection is found
|
raise Exception if an error requiring procedure rejection is found
|
||||||
|
|
||||||
when unknown identifiers are encountered:
|
when unknown identifiers are encountered:
|
||||||
IE buffer value is set with key 'id_%id',
|
IE buffer value is set with key 'id_%id',
|
||||||
|
@ -170,7 +170,7 @@ class LinkSigProc(SigProc):
|
||||||
"""
|
"""
|
||||||
# 1) select the correct PDU and content
|
# 1) select the correct PDU and content
|
||||||
ptype = pdu[0][:3]
|
ptype = pdu[0][:3]
|
||||||
if ptype == 'out':
|
if ptype == 'out':
|
||||||
# some 3G RAN procedure have only 'outcome' pdu
|
# some 3G RAN procedure have only 'outcome' pdu
|
||||||
# which are changed to 'suc'
|
# which are changed to 'suc'
|
||||||
ptype = 'suc'
|
ptype = 'suc'
|
||||||
|
@ -188,8 +188,8 @@ class LinkSigProc(SigProc):
|
||||||
# self._log('WNG', 'decode_pdu: incorrect PDU criticality, %s' % val['criticality'])
|
# self._log('WNG', 'decode_pdu: incorrect PDU criticality, %s' % val['criticality'])
|
||||||
#
|
#
|
||||||
# 3) ensure the PDU content has been properly decoded
|
# 3) ensure the PDU content has been properly decoded
|
||||||
if not isinstance(val['value'], tuple) or \
|
if not isinstance(val, dict) or 'value' not in val \
|
||||||
val['value'][0] != Cont._tr._name:
|
or not isinstance(val['value'], tuple) or val['value'][0] != Cont._tr._name:
|
||||||
raise(CorenetErr('invalid PDU content'))
|
raise(CorenetErr('invalid PDU content'))
|
||||||
#
|
#
|
||||||
# 4) get the value part of the PDU with IEs and Extensions,
|
# 4) get the value part of the PDU with IEs and Extensions,
|
||||||
|
|
Loading…
Reference in New Issue