osmo_dia2gsup/d2fded9068e4cd4a4a6165242b0...

121 lines
3.3 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "4bf75416_2ebc080b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000147
},
"writtenOn": "2022-07-19T10:43:19Z",
"side": 1,
"message": "Thanks, this is much cleaner! LGTM besides the \"rm -rf\" command",
"revId": "d2fded9068e4cd4a4a6165242b0428b1d676930c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "5f2a65c9_6beb3762",
"filename": "debian/osmo-diameter2gsup.install",
"patchSetId": 1
},
"lineNbr": 2,
"author": {
"id": 1000147
},
"writtenOn": "2022-07-19T10:43:19Z",
"side": 1,
"message": "does it still start with the systemd service? I\u0027m not familiar at all with erlang, I though the other libraries were needed at runtime",
"revId": "d2fded9068e4cd4a4a6165242b0428b1d676930c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "a5ccf9b8_6c82f6df",
"filename": "debian/osmo-diameter2gsup.install",
"patchSetId": 1
},
"lineNbr": 2,
"author": {
"id": 1000015
},
"writtenOn": "2022-07-19T13:40:26Z",
"side": 1,
"message": "I\u0027ve missed the update of the service file.",
"parentUuid": "5f2a65c9_6beb3762",
"revId": "d2fded9068e4cd4a4a6165242b0428b1d676930c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "be54a3d4_22f5f379",
"filename": "debian/osmo-diameter2gsup.install",
"patchSetId": 1
},
"lineNbr": 2,
"author": {
"id": 1000015
},
"writtenOn": "2022-07-19T16:00:11Z",
"side": 1,
"message": "Done",
"parentUuid": "a5ccf9b8_6c82f6df",
"revId": "d2fded9068e4cd4a4a6165242b0428b1d676930c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "3c0c5986_e1a47d4d",
"filename": "debian/rules",
"patchSetId": 1
},
"lineNbr": 18,
"author": {
"id": 1000147
},
"writtenOn": "2022-07-19T10:43:19Z",
"side": 1,
"message": "_lib doesn\u0027t get created anymore:\n\n rm -rf _build",
"range": {
"startLine": 18,
"startChar": 15,
"endLine": 18,
"endChar": 19
},
"revId": "d2fded9068e4cd4a4a6165242b0428b1d676930c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "e05033f8_5edd5039",
"filename": "debian/rules",
"patchSetId": 1
},
"lineNbr": 18,
"author": {
"id": 1000015
},
"writtenOn": "2022-07-19T13:40:26Z",
"side": 1,
"message": "Ack",
"parentUuid": "3c0c5986_e1a47d4d",
"range": {
"startLine": 18,
"startChar": 15,
"endLine": 18,
"endChar": 19
},
"revId": "d2fded9068e4cd4a4a6165242b0428b1d676930c",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}