132 lines
3.5 KiB
Plaintext
132 lines
3.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "76f83f10_af0cc1ab",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000074
|
|
},
|
|
"writtenOn": "2023-09-04T09:34:53Z",
|
|
"side": 1,
|
|
"message": "I\u0027m still seeing problems with tests other than 1st one in ttcn3-dia2gsup-test docker setup when running with this patch.",
|
|
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "2fd369bb_d227f10b",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-09-04T09:43:29Z",
|
|
"side": 1,
|
|
"message": "The patch looks good to me in general. Just a few cosmetic things.",
|
|
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "d7a63c86_0c448f7c",
|
|
"filename": "src/gsup_client.erl",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 99,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-09-04T09:43:29Z",
|
|
"side": 1,
|
|
"message": "This sentence looks incomplete: \"failed to ...\" do what?\nNot sure why this part is being changed at all, it looks good as it is to me.",
|
|
"range": {
|
|
"startLine": 99,
|
|
"startChar": 29,
|
|
"endLine": 99,
|
|
"endChar": 38
|
|
},
|
|
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "12ce5ea0_189f43aa",
|
|
"filename": "src/gsup_client.erl",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 99,
|
|
"author": {
|
|
"id": 1000010
|
|
},
|
|
"writtenOn": "2023-09-04T09:43:29Z",
|
|
"side": 1,
|
|
"message": "cosmetic: use tabs",
|
|
"range": {
|
|
"startLine": 99,
|
|
"startChar": 1,
|
|
"endLine": 99,
|
|
"endChar": 17
|
|
},
|
|
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e33345e5_f9ca1a55",
|
|
"filename": "src/gsup_client.erl",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 99,
|
|
"author": {
|
|
"id": 1000015
|
|
},
|
|
"writtenOn": "2023-09-07T12:49:07Z",
|
|
"side": 1,
|
|
"message": "Ack",
|
|
"parentUuid": "d7a63c86_0c448f7c",
|
|
"range": {
|
|
"startLine": 99,
|
|
"startChar": 29,
|
|
"endLine": 99,
|
|
"endChar": 38
|
|
},
|
|
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e6702a28_b35a8f6f",
|
|
"filename": "src/gsup_client.erl",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 99,
|
|
"author": {
|
|
"id": 1000015
|
|
},
|
|
"writtenOn": "2023-09-07T12:49:07Z",
|
|
"side": 1,
|
|
"message": "we need to use an erlang formater. But so far most of the files are mixed between tabs and spaces.",
|
|
"parentUuid": "12ce5ea0_189f43aa",
|
|
"range": {
|
|
"startLine": 99,
|
|
"startChar": 1,
|
|
"endLine": 99,
|
|
"endChar": 17
|
|
},
|
|
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
|
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
|
}
|
|
]
|
|
} |