erlang
/
osmo_dia2gsup
mirror of https://gerrit.osmocom.org/erlang/osmo_dia2gsup
4
0
Fork 1
Code Issues Projects Releases Wiki Activity
osmo_dia2gsup/53f7125cfc7c2ddc9e7e2bdedce...

472 lines
12 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "a291ef51_4c5cdd64",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "Hi Pau,\ndo you found the translation table in TS 29.272 Annex A rel 17? (Diameter to the NAS cause codes and Annex B for the SGSN NAS codes.)",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "a327ade9_73d00a93",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 1000074
},
"writtenOn": "2023-09-01T14:28:18Z",
"side": 1,
"message": "@lynxis please feel free to take over and update the errors as you see fit, I didn\u0027t see the table you mentioned but I\u0027m sure your proposals are fine.",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "40e0d681_4334de09",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 185,
"author": {
"id": 1000074
},
"writtenOn": "2023-08-30T18:52:31Z",
"side": 1,
"message": "I may actually want to return a Result-Code in some of this instead, I need to check what do we have in \"Diameter Base Protocol\"",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "2496ee9c_5b1e4219",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 185,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "40e0d681_4334de09",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "3522f28a_1b60ac91",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 187,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION",
"range": {
"startLine": 187,
"startChar": 62,
"endLine": 187,
"endChar": 92
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "e250c90e_ce6023f5",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 187,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "3522f28a_1b60ac91",
"range": {
"startLine": 187,
"startChar": 62,
"endLine": 187,
"endChar": 92
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "37072e48_ffbfff20",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 189,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "Maybe DIAMETER_AUTHORIZATION_REJECTED would be better.",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "10339261_51088a57",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 189,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "37072e48_ffbfff20",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "bea8ea79_b44624a0",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 191,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION",
"range": {
"startLine": 191,
"startChar": 65,
"endLine": 191,
"endChar": 99
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "256f4ee2_2903f03b",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 191,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "bea8ea79_b44624a0",
"range": {
"startLine": 191,
"startChar": 65,
"endLine": 191,
"endChar": 99
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "7aac8f68_c6c4f7f8",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 192,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "29.272 rel 17: Annex A and Annex B can be used to translate those.\nIMHO: This should be unable_to_comply",
"range": {
"startLine": 192,
"startChar": 55,
"endLine": 192,
"endChar": 95
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "1549bff0_db88a5f4",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 192,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "7aac8f68_c6c4f7f8",
"range": {
"startLine": 192,
"startChar": 55,
"endLine": 192,
"endChar": 95
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "792fb42a_e70dc6eb",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 193,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "I would send unable to comply here, even it is not defined.",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "5b71fda1_e042076a",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 193,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "792fb42a_e70dc6eb",
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "bd2ed798_caa0369c",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 194,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "I would remove this. We should never get this error and we don\u0027t use it on the hlr so far.",
"range": {
"startLine": 194,
"startChar": 16,
"endLine": 194,
"endChar": 43
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "a1c0f9dd_6e44ead9",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 194,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "bd2ed798_caa0369c",
"range": {
"startLine": 194,
"startChar": 16,
"endLine": 194,
"endChar": 43
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "a10c784f_e8056382",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 195,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "DIAMETER_MISSING_AVP",
"range": {
"startLine": 195,
"startChar": 60,
"endLine": 195,
"endChar": 94
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "cb45648b_d59ca70a",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 195,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "a10c784f_e8056382",
"range": {
"startLine": 195,
"startChar": 60,
"endLine": 195,
"endChar": 94
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "b994c2af_75a17b28",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 196,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "DIAMETER_UNABLE_TO_COMPLY",
"range": {
"startLine": 196,
"startChar": 63,
"endLine": 196,
"endChar": 97
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "75dedf38_c7c3ceb7",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 196,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-02T15:52:16Z",
"side": 1,
"message": "Done",
"parentUuid": "b994c2af_75a17b28",
"range": {
"startLine": 196,
"startChar": 63,
"endLine": 196,
"endChar": 97
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": true,
"key": {
"uuid": "82dd6a5a_1f80ace0",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 197,
"author": {
"id": 1000010
},
"writtenOn": "2023-08-30T20:43:34Z",
"side": 1,
"message": "This TODO can be removed I guess?",
"range": {
"startLine": 197,
"startChar": 2,
"endLine": 197,
"endChar": 19
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
},
{
"unresolved": false,
"key": {
"uuid": "85b97d0f_6fa17dfb",
"filename": "src/server_cb.erl",
"patchSetId": 1
},
"lineNbr": 197,
"author": {
"id": 1000015
},
"writtenOn": "2023-09-01T14:12:31Z",
"side": 1,
"message": "not yet.I\u0027ve a patch for this.",
"parentUuid": "82dd6a5a_1f80ace0",
"range": {
"startLine": 197,
"startChar": 2,
"endLine": 197,
"endChar": 19
},
"revId": "53f7125cfc7c2ddc9e7e2bdedceeba3a32eb84d3",
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
}
]
}
Reference in New Issue View Git Blame Copy Permalink