Update patch set 2
Patch Set 2: (3 comments) Patch-set: 2 Attention: {"person_ident":"Gerrit User 1000010 \u003c1000010@035e6965-6537-41bd-912c-053f3cf69326\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_1000010\u003e replied on the change"}
This commit is contained in:
parent
2b38100bec
commit
c8fef86dfc
|
@ -16,6 +16,69 @@
|
|||
"message": "I\u0027m still seeing problems with tests other than 1st one in ttcn3-dia2gsup-test docker setup when running with this patch.",
|
||||
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "2fd369bb_d227f10b",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2023-09-04T09:43:29Z",
|
||||
"side": 1,
|
||||
"message": "The patch looks good to me in general. Just a few cosmetic things.",
|
||||
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d7a63c86_0c448f7c",
|
||||
"filename": "src/gsup_client.erl",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 99,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2023-09-04T09:43:29Z",
|
||||
"side": 1,
|
||||
"message": "This sentence looks incomplete: \"failed to ...\" do what?\nNot sure why this part is being changed at all, it looks good as it is to me.",
|
||||
"range": {
|
||||
"startLine": 99,
|
||||
"startChar": 29,
|
||||
"endLine": 99,
|
||||
"endChar": 38
|
||||
},
|
||||
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "12ce5ea0_189f43aa",
|
||||
"filename": "src/gsup_client.erl",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 99,
|
||||
"author": {
|
||||
"id": 1000010
|
||||
},
|
||||
"writtenOn": "2023-09-04T09:43:29Z",
|
||||
"side": 1,
|
||||
"message": "cosmetic: use tabs",
|
||||
"range": {
|
||||
"startLine": 99,
|
||||
"startChar": 1,
|
||||
"endLine": 99,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "3067b5a4b75f2f1d2535610a2aa4863b5384edcd",
|
||||
"serverId": "035e6965-6537-41bd-912c-053f3cf69326"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue