electronics
/
libopencm3
9
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

stm32l1: rcc/lcd: fix RTCSEL HSE definition 

Wrong since original commit in 2013.

LCD code can't actually automatically determine clock speed if it's HSE,
as we don't know here whether what HSE is, nor what it's divided by.
For more fun, that old 2014 API doesn't have any way of flagging that it
failed either.  Hooray.
This commit is contained in:
Karl Palsson 2020-10-23 15:53:13 +00:00
parent c13c2b3b3c
commit a7902aa4d0
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/libopencm3/stm32/l1/rcc.h
View File

@ -430,7 +430,7 @@
#define RCC_CSR_RTCSEL_NONE (0x0)
#define RCC_CSR_RTCSEL_LSE (0x1)
#define RCC_CSR_RTCSEL_LSI (0x2)
#define RCC_CSR_RTCSEL_HSI (0x3)
#define RCC_CSR_RTCSEL_HSE (0x3)
#define RCC_CSR_LSECSSD (1 << 12)
#define RCC_CSR_LSECSSON (1 << 11)
#define RCC_CSR_LSEBYP (1 << 10)

6
lib/stm32/l1/lcd.c
View File

@ -131,9 +131,9 @@ void lcd_set_refresh_frequency(uint32_t frequency)
case RCC_CSR_RTCSEL_LSI:
lcd_clock = 37000;
break;
case RCC_CSR_RTCSEL_HSI:
lcd_clock = 16000000;
break;
case RCC_CSR_RTCSEL_HSE:
/* no current method of determining clock and divider! */
return;
default:
/* RCC Clock not selected */
return;