![]() After annotating the frame structs, this was left: drivers/ieee1394/dv1394.c:2113:23: warning: invalid assignment: |= drivers/ieee1394/dv1394.c:2113:23: left side has type restricted __le32 drivers/ieee1394/dv1394.c:2113:23: right side has type int drivers/ieee1394/dv1394.c:2121:24: warning: invalid assignment: &= drivers/ieee1394/dv1394.c:2121:24: left side has type restricted __le32 drivers/ieee1394/dv1394.c:2121:24: right side has type int drivers/ieee1394/dv1394.c:2123:24: warning: invalid assignment: |= drivers/ieee1394/dv1394.c:2123:24: left side has type restricted __le32 drivers/ieee1394/dv1394.c:2123:24: right side has type int Which looks like a real bug on a big-endian arch as it would set/clear the wrong bit. Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Bill Fink writes: I finally got a chance to test the patch on my kernel, and live DV viewing using xine still worked fine. Although I admit to being mystified how it works both before and after the patch, since the cpu_to_le32() calls that were added should result in byte swapping on PPC that wasn't being done before. I guess that either the code paths involved aren't actually being triggered by my xine DV viewing, or there's some fortuitous palindromic setting of bits. Tested-by: Bill Fink <billfink@mindspring.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> |
||
---|---|---|
.. | ||
config_roms.c | ||
config_roms.h | ||
csr.c | ||
csr.h | ||
csr1212.c | ||
csr1212.h | ||
dma.c | ||
dma.h | ||
dv1394-private.h | ||
dv1394.c | ||
dv1394.h | ||
eth1394.c | ||
eth1394.h | ||
highlevel.c | ||
highlevel.h | ||
hosts.c | ||
hosts.h | ||
ieee1394-ioctl.h | ||
ieee1394.h | ||
ieee1394_core.c | ||
ieee1394_core.h | ||
ieee1394_hotplug.h | ||
ieee1394_transactions.c | ||
ieee1394_transactions.h | ||
ieee1394_types.h | ||
init_ohci1394_dma.c | ||
iso.c | ||
iso.h | ||
Kconfig | ||
Makefile | ||
nodemgr.c | ||
nodemgr.h | ||
ohci1394.c | ||
ohci1394.h | ||
pcilynx.c | ||
pcilynx.h | ||
raw1394-private.h | ||
raw1394.c | ||
raw1394.h | ||
sbp2.c | ||
sbp2.h | ||
video1394.c | ||
video1394.h |