28735a7253
It's been pointed out that output GPIOs should have an initial value, to avoid signal glitching ... among other things, it can be some time before a driver is ready. This patch corrects that oversight, fixing - documentation - platforms supporting the GPIO interface - users of that call (just one for now, others are pending) There's only one user of this call for now since most platforms are still using non-generic GPIO setup code, which in most cases already couples the initial value with its "set output mode" request. Note that most platforms are clear about the hardware letting the output value be set before the pin direction is changed, but the s3c241x docs are vague on that topic ... so those chips might not avoid the glitches. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Acked-by: Andrew Victor <andrew@sanpeople.com> Acked-by: Milan Svoboda <msvoboda@ra.rockwell.com> Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com> Cc: Russell King <rmk@arm.linux.org.uk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
69 lines
1.8 KiB
C
69 lines
1.8 KiB
C
/*
|
|
* linux/include/asm-arm/arch-s3c2410/gpio.h
|
|
*
|
|
* S3C2410 GPIO wrappers for arch-neutral GPIO calls
|
|
*
|
|
* Written by Philipp Zabel <philipp.zabel@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
*/
|
|
|
|
#ifndef __ASM_ARCH_S3C2410_GPIO_H
|
|
#define __ASM_ARCH_S3C2410_GPIO_H
|
|
|
|
#include <asm/irq.h>
|
|
#include <asm/hardware.h>
|
|
#include <asm/arch/regs-gpio.h>
|
|
|
|
static inline int gpio_request(unsigned gpio, const char *label)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline void gpio_free(unsigned gpio)
|
|
{
|
|
return;
|
|
}
|
|
|
|
static inline int gpio_direction_input(unsigned gpio)
|
|
{
|
|
s3c2410_gpio_cfgpin(gpio, S3C2410_GPIO_INPUT);
|
|
return 0;
|
|
}
|
|
|
|
static inline int gpio_direction_output(unsigned gpio, int value)
|
|
{
|
|
s3c2410_gpio_cfgpin(gpio, S3C2410_GPIO_OUTPUT);
|
|
/* REVISIT can we write the value first, to avoid glitching? */
|
|
s3c2410_gpio_setpin(gpio, value);
|
|
return 0;
|
|
}
|
|
|
|
#define gpio_get_value(gpio) s3c2410_gpio_getpin(gpio)
|
|
#define gpio_set_value(gpio,value) s3c2410_gpio_setpin(gpio, value)
|
|
|
|
#include <asm-generic/gpio.h> /* cansleep wrappers */
|
|
|
|
#ifdef CONFIG_CPU_S3C2400
|
|
#define gpio_to_irq(gpio) s3c2400_gpio_getirq(gpio)
|
|
#else
|
|
#define gpio_to_irq(gpio) s3c2410_gpio_getirq(gpio)
|
|
#endif
|
|
|
|
/* FIXME implement irq_to_gpio() */
|
|
|
|
#endif
|