This repository has been archived on 2022-02-17. You can view files and clone it, but cannot push or open issues or pull requests.

Greg Edwards d8190dff01 bonding: set device in RLB ARP packet handler ... After: commit 6146b1a4da Author: Jay Vosburgh <fubar@us.ibm.com> Date: Tue Nov 4 17:51:15 2008 -0800 bonding: Fix ALB mode to balance traffic on VLANs the dev field in the RLB ARP packet handler was set to NULL to wildcard and accommodate balancing VLANs on top of bonds. This has the side-effect of the packet handler being called against other, non RLB-enabled bonds, and a kernel oops results when it tries to dereference rx_hashtbl in rlb_update_entry_from_arp(), which won't be set for those bonds, e.g. active-backup. With the __netif_receive_skb() changes from: commit 1f3c8804ac Author: Andy Gospodarek <andy@greyhouse.net> Date: Mon Dec 14 10:48:58 2009 +0000 bonding: allow arp_ip_targets on separate vlans to use arp validation frames received on VLANs correctly make their way to the bond's handler, so we no longer need to wildcard the device. The oops can be reproduced by: modprobe bonding echo active-backup > /sys/class/net/bond0/bonding/mode echo 100 > /sys/class/net/bond0/bonding/miimon ifconfig bond0 xxx.xxx.xxx.xxx netmask xxx.xxx.xxx.xxx echo +eth0 > /sys/class/net/bond0/bonding/slaves echo +eth1 > /sys/class/net/bond0/bonding/slaves echo +bond1 > /sys/class/net/bonding_masters echo balance-alb > /sys/class/net/bond1/bonding/mode echo 100 > /sys/class/net/bond1/bonding/miimon ifconfig bond1 xxx.xxx.xxx.xxx netmask xxx.xxx.xxx.xxx echo +eth2 > /sys/class/net/bond1/bonding/slaves echo +eth3 > /sys/class/net/bond1/bonding/slaves Pass some traffic on bond0. Boom. [ Tested, behaves as advertised. I do not believe a test of the bonding mode is necessary, as there is no race between the packet handler and the bonding mode changing (the mode can only change when the device is closed). Also updated the log message to include the reproduction and full commit ids. -J ] Signed-off-by: Greg Edwards <greg.edwards@hp.com> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com> Acked-by: Andy Gospodarek <andy@greyhouse.net> Signed-off-by: David S. Miller <davem@davemloft.net>		2010-07-24 20:37:48 -07:00
..
Makefile	bonding: send IPv6 neighbor advertisement on failover	2008-11-06 00:49:37 -05:00
bond_3ad.c	bond_3ad.c avoid possible null deref	2009-12-26 20:24:46 -08:00
bond_3ad.h	Remove duplicate slow protocol define in bond_3ad.h	2009-05-09 13:15:49 -07:00
bond_alb.c	bonding: set device in RLB ARP packet handler	2010-07-24 20:37:48 -07:00
bond_alb.h	Convert bonding timers to workqueues	2007-10-23 20:32:00 -04:00
bond_ipv6.c	ipv6: convert idev_list to list macros	2010-03-20 15:45:09 -07:00
bond_main.c	bonding: prevent netpoll over bonded interfaces	2010-06-28 23:54:10 -07:00
bond_sysfs.c	driver-core: Add attribute argument to class_attribute show/store	2010-03-07 17:04:48 -08:00
bonding.h	net: convert multicast list to list_head	2010-04-03 14:22:15 -07:00