dect
/
linux-2.6
Archived
13
0
Fork 0
This repository has been archived on 2022-02-17. You can view files and clone it, but cannot push or open issues or pull requests.
linux-2.6/drivers/net/tulip
David S. Miller 689be43945 [NET]: Remove gratuitous use of skb->tail in network drivers.
Many drivers use skb->tail unnecessarily.

In these situations, the code roughly looks like:

	dev = dev_alloc_skb(...);

	[optional] skb_reserve(skb, ...);

	... skb->tail ...

But even if the skb_reserve() happens, skb->data equals
skb->tail.  So it doesn't make any sense to use anything
other than skb->data in these cases.

Another case was the s2io.c driver directly mucking with
the skb->data and skb->tail pointers.  It really just wanted
to do an skb_reserve(), so that's what the code was changed
to do instead.

Another reason I'm making this change as it allows some SKB
cleanups I have planned simpler to merge.  In those cleanups,
skb->head, skb->tail, and skb->end pointers are removed, and
replaced with skb->head_room and skb->tail_room integers.

Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Jeff Garzik <jgarzik@pobox.com>
2005-06-28 15:25:31 -07:00
..
21142.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Kconfig Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
de4x5.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
de4x5.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
de2104x.c [NET]: Remove gratuitous use of skb->tail in network drivers. 2005-06-28 15:25:31 -07:00
dmfe.c [NET]: Remove gratuitous use of skb->tail in network drivers. 2005-06-28 15:25:31 -07:00
eeprom.c Tulip fixes for Cobalt Qube/RaQ 2005-06-26 17:45:52 -04:00
interrupt.c [NET]: Remove gratuitous use of skb->tail in network drivers. 2005-06-28 15:25:31 -07:00
media.c Tulip fixes for Cobalt Qube/RaQ 2005-06-26 17:45:52 -04:00
pnic.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
pnic2.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
timer.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
tulip.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
tulip_core.c [NET]: Remove gratuitous use of skb->tail in network drivers. 2005-06-28 15:25:31 -07:00
winbond-840.c [NET]: Remove gratuitous use of skb->tail in network drivers. 2005-06-28 15:25:31 -07:00
xircom_cb.c Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
xircom_tulip_cb.c [NET]: Remove gratuitous use of skb->tail in network drivers. 2005-06-28 15:25:31 -07:00