17fb76165f
Since in each case nothing has been done with the recently allocated urb, it is not necessary to kill it before freeing it. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ expression urb; statement S; position p1,p2; @@ urb = usb_alloc_urb@p1(...); ... when != urb if (urb == NULL) S ... when != urb usb_kill_urb@p2(urb); @other exists@ position r.p1,r.p2; @@ ... when != usb_alloc_urb@p1(...) usb_kill_urb@p2(...); @depends on !other exists@ expression urb; position r.p1,r.p2; @@ urb = usb_alloc_urb@p1(...); ... ( -usb_kill_urb@p2(urb); +usb_free_urb(urb); ... when != urb | -usb_kill_urb@p2(urb); ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
||
|---|---|---|
| .. | ||
| 80211hdr.h | ||
| 80211mgr.c | ||
| 80211mgr.h | ||
| aes_ccmp.c | ||
| aes_ccmp.h | ||
| baseband.c | ||
| baseband.h | ||
| bssdb.c | ||
| bssdb.h | ||
| card.c | ||
| card.h | ||
| channel.c | ||
| channel.h | ||
| control.c | ||
| control.h | ||
| country.h | ||
| datarate.c | ||
| datarate.h | ||
| desc.h | ||
| device.h | ||
| device_cfg.h | ||
| dpc.c | ||
| dpc.h | ||
| firmware.c | ||
| firmware.h | ||
| hostap.c | ||
| hostap.h | ||
| int.c | ||
| int.h | ||
| iocmd.h | ||
| ioctl.c | ||
| ioctl.h | ||
| iowpa.h | ||
| iwctl.c | ||
| iwctl.h | ||
| Kconfig | ||
| key.c | ||
| key.h | ||
| mac.c | ||
| mac.h | ||
| main_usb.c | ||
| Makefile | ||
| mib.c | ||
| mib.h | ||
| michael.c | ||
| michael.h | ||
| power.c | ||
| power.h | ||
| rc4.c | ||
| rc4.h | ||
| rf.c | ||
| rf.h | ||
| rndis.h | ||
| rxtx.c | ||
| rxtx.h | ||
| srom.h | ||
| tcrc.c | ||
| tcrc.h | ||
| tether.c | ||
| tether.h | ||
| tkip.c | ||
| tkip.h | ||
| tmacro.h | ||
| TODO | ||
| ttype.h | ||
| upc.h | ||
| usbpipe.c | ||
| usbpipe.h | ||
| vntconfiguration.dat | ||
| wcmd.c | ||
| wcmd.h | ||
| wctl.c | ||
| wctl.h | ||
| wmgr.c | ||
| wmgr.h | ||
| wpa.c | ||
| wpa.h | ||
| wpa2.c | ||
| wpa2.h | ||
| wpactl.c | ||
| wpactl.h | ||