dect
/
linux-2.6
Archived
13
0
Fork 0
This repository has been archived on 2022-02-17. You can view files and clone it, but cannot push or open issues or pull requests.
linux-2.6/fs/udf
Christoph Lameter 50953fe9e0 slab allocators: Remove SLAB_DEBUG_INITIAL flag
I have never seen a use of SLAB_DEBUG_INITIAL.  It is only supported by
SLAB.

I think its purpose was to have a callback after an object has been freed
to verify that the state is the constructor state again?  The callback is
performed before each freeing of an object.

I would think that it is much easier to check the object state manually
before the free.  That also places the check near the code object
manipulation of the object.

Also the SLAB_DEBUG_INITIAL callback is only performed if the kernel was
compiled with SLAB debugging on.  If there would be code in a constructor
handling SLAB_DEBUG_INITIAL then it would have to be conditional on
SLAB_DEBUG otherwise it would just be dead code.  But there is no such code
in the kernel.  I think SLUB_DEBUG_INITIAL is too problematic to make real
use of, difficult to understand and there are easier ways to accomplish the
same effect (i.e.  add debug code before kfree).

There is a related flag SLAB_CTOR_VERIFY that is frequently checked to be
clear in fs inode caches.  Remove the pointless checks (they would even be
pointless without removeal of SLAB_DEBUG_INITIAL) from the fs constructors.

This is the last slab flag that SLUB did not support.  Remove the check for
unimplemented flags from SLUB.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-07 12:12:57 -07:00
..
Makefile Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
balloc.c [PATCH] sem2mutex: UDF 2006-03-23 07:38:14 -08:00
crc.c remove pointers to the defunct UDF mailing list 2006-01-03 13:19:13 +01:00
dir.c [PATCH] struct path: convert udf 2006-12-08 08:28:50 -08:00
directory.c remove pointers to the defunct UDF mailing list 2006-01-03 13:19:13 +01:00
ecma_167.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
file.c [PATCH] mark struct inode_operations const 3 2007-02-12 09:48:46 -08:00
fsync.c remove pointers to the defunct UDF mailing list 2006-01-03 13:19:13 +01:00
ialloc.c [PATCH] inode-diet: Eliminate i_blksize from the inode structure 2006-09-27 08:26:18 -07:00
inode.c [PATCH] r/o bind mount prepwork: inc_nlink() helper 2006-10-01 00:39:30 -07:00
lowlevel.c remove pointers to the defunct UDF mailing list 2006-01-03 13:19:13 +01:00
misc.c remove pointers to the defunct UDF mailing list 2006-01-03 13:19:13 +01:00
namei.c [PATCH] mark struct inode_operations const 3 2007-02-12 09:48:46 -08:00
osta_udf.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
partition.c remove pointers to the defunct UDF mailing list 2006-01-03 13:19:13 +01:00
super.c slab allocators: Remove SLAB_DEBUG_INITIAL flag 2007-05-07 12:12:57 -07:00
symlink.c [PATCH] mark address_space_operations const 2006-06-28 14:59:04 -07:00
truncate.c Fix possible UDF deadlock and memory corruption (CVE-2006-4145) 2006-08-22 12:52:23 -07:00
udf_i.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
udf_sb.h [PATCH] udf: fix uid/gid options and add uid/gid=ignore and forget options 2006-03-08 14:14:00 -08:00
udfdecl.h [PATCH] mark struct inode_operations const 3 2007-02-12 09:48:46 -08:00
udfend.h Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
udftime.c [PATCH] UDF filesystem: array '__mon_yday' declared as not static 2005-05-31 14:54:18 -07:00
unicode.c remove pointers to the defunct UDF mailing list 2006-01-03 13:19:13 +01:00