![Anton Blanchard](/assets/img/avatar_default.png)
I recently had a BUG_ON() go off spuriously on a gcc 4.0 compiled kernel. It turns out gcc-4.0 was removing a sign extension while earlier gcc versions would not. Thinking this to be a compiler bug, I submitted a report: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=23422 It turns out we need to cast the input in order to tell gcc to sign extend it. Thanks to Andrew Pinski for his help on this bug. Signed-off-by: Anton Blanchard <anton@samba.org> Cc: Paul Mackerras <paulus@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
70 lines
1.6 KiB
C
70 lines
1.6 KiB
C
#ifndef _PPC64_BUG_H
|
|
#define _PPC64_BUG_H
|
|
|
|
/*
|
|
* Define an illegal instr to trap on the bug.
|
|
* We don't use 0 because that marks the end of a function
|
|
* in the ELF ABI. That's "Boo Boo" in case you wonder...
|
|
*/
|
|
#define BUG_OPCODE .long 0x00b00b00 /* For asm */
|
|
#define BUG_ILLEGAL_INSTR "0x00b00b00" /* For BUG macro */
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
struct bug_entry {
|
|
unsigned long bug_addr;
|
|
long line;
|
|
const char *file;
|
|
const char *function;
|
|
};
|
|
|
|
struct bug_entry *find_bug(unsigned long bugaddr);
|
|
|
|
/*
|
|
* If this bit is set in the line number it means that the trap
|
|
* is for WARN_ON rather than BUG or BUG_ON.
|
|
*/
|
|
#define BUG_WARNING_TRAP 0x1000000
|
|
|
|
#ifdef CONFIG_BUG
|
|
|
|
#define BUG() do { \
|
|
__asm__ __volatile__( \
|
|
"1: twi 31,0,0\n" \
|
|
".section __bug_table,\"a\"\n\t" \
|
|
" .llong 1b,%0,%1,%2\n" \
|
|
".previous" \
|
|
: : "i" (__LINE__), "i" (__FILE__), "i" (__FUNCTION__)); \
|
|
} while (0)
|
|
|
|
#define BUG_ON(x) do { \
|
|
__asm__ __volatile__( \
|
|
"1: tdnei %0,0\n" \
|
|
".section __bug_table,\"a\"\n\t" \
|
|
" .llong 1b,%1,%2,%3\n" \
|
|
".previous" \
|
|
: : "r" ((long long)(x)), "i" (__LINE__), \
|
|
"i" (__FILE__), "i" (__FUNCTION__)); \
|
|
} while (0)
|
|
|
|
#define WARN_ON(x) do { \
|
|
__asm__ __volatile__( \
|
|
"1: tdnei %0,0\n" \
|
|
".section __bug_table,\"a\"\n\t" \
|
|
" .llong 1b,%1,%2,%3\n" \
|
|
".previous" \
|
|
: : "r" ((long long)(x)), \
|
|
"i" (__LINE__ + BUG_WARNING_TRAP), \
|
|
"i" (__FILE__), "i" (__FUNCTION__)); \
|
|
} while (0)
|
|
|
|
#define HAVE_ARCH_BUG
|
|
#define HAVE_ARCH_BUG_ON
|
|
#define HAVE_ARCH_WARN_ON
|
|
#endif
|
|
#endif
|
|
|
|
#include <asm-generic/bug.h>
|
|
|
|
#endif
|