![]() First of all it is unnecessary to allocate a new skb in skb_pad since the existing one is not shared. More importantly, our hard_start_xmit interface does not allow a new skb to be allocated since that breaks requeueing. This patch uses pskb_expand_head to expand the existing skb and linearize it if needed. Actually, someone should sift through every instance of skb_pad on a non-linear skb as they do not fit the reasons why this was originally created. Incidentally, this fixes a minor bug when the skb is cloned (tcpdump, TCP, etc.). As it is skb_pad will simply write over a cloned skb. Because of the position of the write it is unlikely to cause problems but still it's best if we don't do it. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: David S. Miller <davem@davemloft.net> |
||
---|---|---|
.. | ||
3c574_cs.c | ||
3c589_cs.c | ||
axnet_cs.c | ||
com20020_cs.c | ||
fmvj18x_cs.c | ||
ibmtr_cs.c | ||
Kconfig | ||
Makefile | ||
nmclan_cs.c | ||
ositech.h | ||
pcnet_cs.c | ||
smc91c92_cs.c | ||
xirc2ps_cs.c |