dect
/
linux-2.6
Archived
13
0
Fork 0
This repository has been archived on 2022-02-17. You can view files and clone it, but cannot push or open issues or pull requests.
linux-2.6/fs/9p
Sukadev Bhattiprolu a3ec947c85 vfs: simple_set_mnt() should return void
simple_set_mnt() is defined as returning 'int' but always returns 0.
Callers assume simple_set_mnt() never fails and don't properly cleanup if
it were to _ever_ fail.  For instance, get_sb_single() and get_sb_nodev()
should:

        up_write(sb->s_unmount);
        deactivate_super(sb);

if simple_set_mnt() fails.

Since simple_set_mnt() never fails, would be cleaner if it did not
return anything.

[akpm@linux-foundation.org: fix build]
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2009-03-27 14:44:03 -04:00
..
Kconfig fs/Kconfig: move 9p out 2009-01-22 13:16:01 +03:00
Makefile 9p: Reorganization of 9p file system code 2007-07-14 15:13:40 -05:00
fid.c Merge branch 'next' into for-linus 2008-12-25 11:40:09 +11:00
fid.h 9p: Documentation updates 2008-05-14 19:23:25 -05:00
v9fs.c fs/9p: change simple_strtol to simple_strtoul 2008-12-19 16:50:22 -06:00
v9fs.h 9p: Documentation updates 2008-05-14 19:23:25 -05:00
v9fs_vfs.h constify dentry_operations: 9p 2009-03-27 14:44:00 -04:00
vfs_addr.c 9p: move readn meta-function from client to fs layer 2008-10-17 11:04:43 -05:00
vfs_dentry.c constify dentry_operations: 9p 2009-03-27 14:44:00 -04:00
vfs_dir.c 9p: eliminate depricated conv functions 2008-10-17 11:06:57 -05:00
vfs_file.c 9p: fix format warning 2008-10-22 18:48:45 -05:00
vfs_inode.c Merge branch 'next' into for-linus 2008-12-25 11:40:09 +11:00
vfs_super.c vfs: simple_set_mnt() should return void 2009-03-27 14:44:03 -04:00