![Mike Travis](/assets/img/avatar_default.png)
Impact: fix potential APIC crash In determining the destination apicid, there are usually three cpumasks that are considered: the incoming cpumask arg, cfg->domain and the cpu_online_mask. Since we are just introducing the cpu_mask_to_apicid_and function, make sure it includes the cpu_online_mask in it's evaluation. [Added with this patch.] There are two io_apic.c functions that did not previously use the cpu_online_mask: setup_IO_APIC_irq and msi_compose_msg. Both of these simply used cpu_mask_to_apicid(cfg->domain & TARGET_CPUS), and all but one arch (NUMAQ[*]) returns only online cpus in the TARGET_CPUS mask, so the behavior is identical for all cases. [*: NUMAQ bug?] Note that alloc_cpumask_var is only used for the 32-bit cases where it's highly likely that the cpumask set size will be small and therefore CPUMASK_OFFSTACK=n. But if that's not the case, failing the allocate will cause the same return value as the default. Signed-off-by: Mike Travis <travis@sgi.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
169 lines
4.4 KiB
C
169 lines
4.4 KiB
C
#ifndef _ASM_X86_MACH_DEFAULT_MACH_APIC_H
|
|
#define _ASM_X86_MACH_DEFAULT_MACH_APIC_H
|
|
|
|
#ifdef CONFIG_X86_LOCAL_APIC
|
|
|
|
#include <mach_apicdef.h>
|
|
#include <asm/smp.h>
|
|
|
|
#define APIC_DFR_VALUE (APIC_DFR_FLAT)
|
|
|
|
static inline const struct cpumask *target_cpus(void)
|
|
{
|
|
#ifdef CONFIG_SMP
|
|
return cpu_online_mask;
|
|
#else
|
|
return cpumask_of(0);
|
|
#endif
|
|
}
|
|
|
|
#define NO_BALANCE_IRQ (0)
|
|
#define esr_disable (0)
|
|
|
|
#ifdef CONFIG_X86_64
|
|
#include <asm/genapic.h>
|
|
#define INT_DELIVERY_MODE (genapic->int_delivery_mode)
|
|
#define INT_DEST_MODE (genapic->int_dest_mode)
|
|
#define TARGET_CPUS (genapic->target_cpus())
|
|
#define apic_id_registered (genapic->apic_id_registered)
|
|
#define init_apic_ldr (genapic->init_apic_ldr)
|
|
#define cpu_mask_to_apicid (genapic->cpu_mask_to_apicid)
|
|
#define cpu_mask_to_apicid_and (genapic->cpu_mask_to_apicid_and)
|
|
#define phys_pkg_id (genapic->phys_pkg_id)
|
|
#define vector_allocation_domain (genapic->vector_allocation_domain)
|
|
#define read_apic_id() (GET_APIC_ID(apic_read(APIC_ID)))
|
|
#define send_IPI_self (genapic->send_IPI_self)
|
|
#define wakeup_secondary_cpu (genapic->wakeup_cpu)
|
|
extern void setup_apic_routing(void);
|
|
#else
|
|
#define INT_DELIVERY_MODE dest_LowestPrio
|
|
#define INT_DEST_MODE 1 /* logical delivery broadcast to all procs */
|
|
#define TARGET_CPUS (target_cpus())
|
|
#define wakeup_secondary_cpu wakeup_secondary_cpu_via_init
|
|
/*
|
|
* Set up the logical destination ID.
|
|
*
|
|
* Intel recommends to set DFR, LDR and TPR before enabling
|
|
* an APIC. See e.g. "AP-388 82489DX User's Manual" (Intel
|
|
* document number 292116). So here it goes...
|
|
*/
|
|
static inline void init_apic_ldr(void)
|
|
{
|
|
unsigned long val;
|
|
|
|
apic_write(APIC_DFR, APIC_DFR_VALUE);
|
|
val = apic_read(APIC_LDR) & ~APIC_LDR_MASK;
|
|
val |= SET_APIC_LOGICAL_ID(1UL << smp_processor_id());
|
|
apic_write(APIC_LDR, val);
|
|
}
|
|
|
|
static inline int apic_id_registered(void)
|
|
{
|
|
return physid_isset(read_apic_id(), phys_cpu_present_map);
|
|
}
|
|
|
|
static inline unsigned int cpu_mask_to_apicid(const struct cpumask *cpumask)
|
|
{
|
|
return cpumask_bits(cpumask)[0];
|
|
}
|
|
|
|
static inline unsigned int cpu_mask_to_apicid_and(const struct cpumask *cpumask,
|
|
const struct cpumask *andmask)
|
|
{
|
|
unsigned long mask1 = cpumask_bits(cpumask)[0];
|
|
unsigned long mask2 = cpumask_bits(andmask)[0];
|
|
unsigned long mask3 = cpumask_bits(cpu_online_mask)[0];
|
|
|
|
return (unsigned int)(mask1 & mask2 & mask3);
|
|
}
|
|
|
|
static inline u32 phys_pkg_id(u32 cpuid_apic, int index_msb)
|
|
{
|
|
return cpuid_apic >> index_msb;
|
|
}
|
|
|
|
static inline void setup_apic_routing(void)
|
|
{
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
printk("Enabling APIC mode: %s. Using %d I/O APICs\n",
|
|
"Flat", nr_ioapics);
|
|
#endif
|
|
}
|
|
|
|
static inline int apicid_to_node(int logical_apicid)
|
|
{
|
|
#ifdef CONFIG_SMP
|
|
return apicid_2_node[hard_smp_processor_id()];
|
|
#else
|
|
return 0;
|
|
#endif
|
|
}
|
|
|
|
static inline void vector_allocation_domain(int cpu, struct cpumask *retmask)
|
|
{
|
|
/* Careful. Some cpus do not strictly honor the set of cpus
|
|
* specified in the interrupt destination when using lowest
|
|
* priority interrupt delivery mode.
|
|
*
|
|
* In particular there was a hyperthreading cpu observed to
|
|
* deliver interrupts to the wrong hyperthread when only one
|
|
* hyperthread was specified in the interrupt desitination.
|
|
*/
|
|
*retmask = (cpumask_t) { { [0] = APIC_ALL_CPUS } };
|
|
}
|
|
#endif
|
|
|
|
static inline unsigned long check_apicid_used(physid_mask_t bitmap, int apicid)
|
|
{
|
|
return physid_isset(apicid, bitmap);
|
|
}
|
|
|
|
static inline unsigned long check_apicid_present(int bit)
|
|
{
|
|
return physid_isset(bit, phys_cpu_present_map);
|
|
}
|
|
|
|
static inline physid_mask_t ioapic_phys_id_map(physid_mask_t phys_map)
|
|
{
|
|
return phys_map;
|
|
}
|
|
|
|
static inline int multi_timer_check(int apic, int irq)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
/* Mapping from cpu number to logical apicid */
|
|
static inline int cpu_to_logical_apicid(int cpu)
|
|
{
|
|
return 1 << cpu;
|
|
}
|
|
|
|
static inline int cpu_present_to_apicid(int mps_cpu)
|
|
{
|
|
if (mps_cpu < nr_cpu_ids && cpu_present(mps_cpu))
|
|
return (int)per_cpu(x86_bios_cpu_apicid, mps_cpu);
|
|
else
|
|
return BAD_APICID;
|
|
}
|
|
|
|
static inline physid_mask_t apicid_to_cpu_present(int phys_apicid)
|
|
{
|
|
return physid_mask_of_physid(phys_apicid);
|
|
}
|
|
|
|
static inline void setup_portio_remap(void)
|
|
{
|
|
}
|
|
|
|
static inline int check_phys_apicid_present(int boot_cpu_physical_apicid)
|
|
{
|
|
return physid_isset(boot_cpu_physical_apicid, phys_cpu_present_map);
|
|
}
|
|
|
|
static inline void enable_apic_mode(void)
|
|
{
|
|
}
|
|
#endif /* CONFIG_X86_LOCAL_APIC */
|
|
#endif /* _ASM_X86_MACH_DEFAULT_MACH_APIC_H */
|