dect
/
linux-2.6
Archived
13
0
Fork 0
This repository has been archived on 2022-02-17. You can view files and clone it, but cannot push or open issues or pull requests.
linux-2.6/arch/arm/mach-sa1100
Russell King b1b3f49ce4 ARM: config: sort select statements alphanumerically
As suggested by Andrew Morton:

  This is a pet peeve of mine.  Any time there's a long list of items
  (header file inclusions, kconfig entries, array initalisers, etc) and
  someone wants to add a new item, they *always* go and stick it at the
  end of the list.

  Guys, don't do this.  Either put the new item into a randomly-chosen
  position or, probably better, alphanumerically sort the list.

lets sort all our select statements alphanumerically.  This commit was
created by the following perl:

while (<>) {
	while (/\\\s*$/) {
		$_ .= <>;
	}
	undef %selects if /^\s*config\s+/;
	if (/^\s+select\s+(\w+).*/) {
		if (defined($selects{$1})) {
			if ($selects{$1} eq $_) {
				print STDERR "Warning: removing duplicated $1 entry\n";
			} else {
				print STDERR "Error: $1 differently selected\n".
					"\tOld: $selects{$1}\n".
					"\tNew: $_\n";
				exit 1;
			}
		}
		$selects{$1} = $_;
		next;
	}
	if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
			  /^endif/ or /^endchoice/)) {
		foreach $k (sort (keys %selects)) {
			print "$selects{$k}";
		}
		undef %selects;
	}
	print;
}
if (%selects) {
	foreach $k (sort (keys %selects)) {
		print "$selects{$k}";
	}
}

It found two duplicates:

Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry

and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.

We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)

Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
2012-10-13 17:11:28 +01:00
..
include/mach Merge branch 'for-linus' of git://git.linaro.org/people/rmk/linux-arm 2012-10-07 21:20:57 +09:00
Kconfig ARM: config: sort select statements alphanumerically 2012-10-13 17:11:28 +01:00
Makefile ARM: mach-sa1100: retire custom LED code 2012-08-01 11:22:14 +08:00
Makefile.boot ARM: sa1100: fix build error 2011-12-08 14:55:57 +08:00
assabet.c ARM: assabet: fix bogus warning in get_assabet_scr (again) 2012-10-09 17:27:01 +02:00
badge4.c ARM: mach-sa1100: retire custom LED code 2012-08-01 11:22:14 +08:00
cerf.c ARM: soc: multiplatform enablement 2012-10-01 19:11:38 -07:00
clock.c ARM: sa1100: clean up clock support 2012-02-28 10:08:07 +08:00
collie.c ARM: sa1100: move platform_data definitions 2012-09-14 11:18:57 +02:00
cpu-sa1100.c ARM: sa11x0/pxa: convert OS timer registers to IOMEM 2012-07-09 17:37:35 +01:00
cpu-sa1110.c ARM: sa11x0/pxa: convert OS timer registers to IOMEM 2012-07-09 17:37:35 +01:00
generic.c Merge branch 'clean/late_initcall_v2' of git://git.linaro.org/people/shawnguo/linux-2.6 into staging/cleanup 2012-05-11 00:49:56 -07:00
generic.h ARM: sa1100: use machine specific hook for late init 2012-05-08 20:36:34 +08:00
h3xxx.c ARM: sa11x0: convert to use DEFINE_RES_xxx macros 2012-02-09 15:34:12 +00:00
h3100.c ARM: sa1100: use machine specific hook for late init 2012-05-08 20:36:34 +08:00
h3600.c ARM: sa1100: use machine specific hook for late init 2012-05-08 20:36:34 +08:00
hackkit.c ARM: mach-sa1100: retire custom LED code 2012-08-01 11:22:14 +08:00
irq.c ARM: sa11x0/pxa: convert OS timer registers to IOMEM 2012-07-09 17:37:35 +01:00
jornada720.c ARM: sa1100: use machine specific hook for late init 2012-05-08 20:36:34 +08:00
jornada720_ssp.c ARM: sa11x0/pxa: convert OS timer registers to IOMEM 2012-07-09 17:37:35 +01:00
lart.c ARM: soc: multiplatform enablement 2012-10-01 19:11:38 -07:00
nanoengine.c ARM: sa1100: use machine specific hook for late init 2012-05-08 20:36:34 +08:00
neponset.c ARM: neponset: make sure neponset_ncr_frob() is exported 2012-05-25 08:41:53 +01:00
pci-nanoengine.c ARM: PCI: provide a default bus scan implementation 2012-05-13 17:12:17 +01:00
pleb.c ARM: sa1100: use machine specific hook for late init 2012-05-08 20:36:34 +08:00
pm.c ARM: sa11x0/pxa: convert OS timer registers to IOMEM 2012-07-09 17:37:35 +01:00
shannon.c ARM: sa1100: move platform_data definitions 2012-09-14 11:18:57 +02:00
simpad.c ARM: soc: multiplatform enablement 2012-10-01 19:11:38 -07:00
sleep.S ARM: 7452/1: delay: allow timer-based delay implementation to be selected 2012-07-09 17:42:23 +01:00
ssp.c ARM: 7342/2: sa1100: prepare for sparse irq conversion 2012-03-25 23:57:20 +01:00
time.c ARM: sa11x0/pxa: convert OS timer registers to IOMEM 2012-07-09 17:37:35 +01:00