![Andi Kleen](/assets/img/avatar_default.png)
Use correct address when referencing mmconfig aperture while checking for broken MCFG. This was a typo when porting the code from 64bit to 32bit. It caused oopses at boot on some ThinkPads. Should definitely go into 2.6.15. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
186 lines
4.3 KiB
C
186 lines
4.3 KiB
C
/*
|
|
* Copyright (C) 2004 Matthew Wilcox <matthew@wil.cx>
|
|
* Copyright (C) 2004 Intel Corp.
|
|
*
|
|
* This code is released under the GNU General Public License version 2.
|
|
*/
|
|
|
|
/*
|
|
* mmconfig.c - Low-level direct PCI config space access via MMCONFIG
|
|
*/
|
|
|
|
#include <linux/pci.h>
|
|
#include <linux/init.h>
|
|
#include <linux/acpi.h>
|
|
#include "pci.h"
|
|
|
|
#define mmcfg_virt_addr ((void __iomem *) fix_to_virt(FIX_PCIE_MCFG))
|
|
|
|
/* The base address of the last MMCONFIG device accessed */
|
|
static u32 mmcfg_last_accessed_device;
|
|
|
|
static DECLARE_BITMAP(fallback_slots, 32);
|
|
|
|
/*
|
|
* Functions for accessing PCI configuration space with MMCONFIG accesses
|
|
*/
|
|
static u32 get_base_addr(unsigned int seg, int bus, unsigned devfn)
|
|
{
|
|
int cfg_num = -1;
|
|
struct acpi_table_mcfg_config *cfg;
|
|
|
|
if (seg == 0 && bus == 0 &&
|
|
test_bit(PCI_SLOT(devfn), fallback_slots))
|
|
return 0;
|
|
|
|
while (1) {
|
|
++cfg_num;
|
|
if (cfg_num >= pci_mmcfg_config_num) {
|
|
/* Not found - fallback to type 1 */
|
|
return 0;
|
|
}
|
|
cfg = &pci_mmcfg_config[cfg_num];
|
|
if (cfg->pci_segment_group_number != seg)
|
|
continue;
|
|
if ((cfg->start_bus_number <= bus) &&
|
|
(cfg->end_bus_number >= bus))
|
|
return cfg->base_address;
|
|
}
|
|
}
|
|
|
|
static inline void pci_exp_set_dev_base(unsigned int base, int bus, int devfn)
|
|
{
|
|
u32 dev_base = base | (bus << 20) | (devfn << 12);
|
|
if (dev_base != mmcfg_last_accessed_device) {
|
|
mmcfg_last_accessed_device = dev_base;
|
|
set_fixmap_nocache(FIX_PCIE_MCFG, dev_base);
|
|
}
|
|
}
|
|
|
|
static int pci_mmcfg_read(unsigned int seg, unsigned int bus,
|
|
unsigned int devfn, int reg, int len, u32 *value)
|
|
{
|
|
unsigned long flags;
|
|
u32 base;
|
|
|
|
if (!value || (bus > 255) || (devfn > 255) || (reg > 4095))
|
|
return -EINVAL;
|
|
|
|
base = get_base_addr(seg, bus, devfn);
|
|
if (!base)
|
|
return pci_conf1_read(seg,bus,devfn,reg,len,value);
|
|
|
|
spin_lock_irqsave(&pci_config_lock, flags);
|
|
|
|
pci_exp_set_dev_base(base, bus, devfn);
|
|
|
|
switch (len) {
|
|
case 1:
|
|
*value = readb(mmcfg_virt_addr + reg);
|
|
break;
|
|
case 2:
|
|
*value = readw(mmcfg_virt_addr + reg);
|
|
break;
|
|
case 4:
|
|
*value = readl(mmcfg_virt_addr + reg);
|
|
break;
|
|
}
|
|
|
|
spin_unlock_irqrestore(&pci_config_lock, flags);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int pci_mmcfg_write(unsigned int seg, unsigned int bus,
|
|
unsigned int devfn, int reg, int len, u32 value)
|
|
{
|
|
unsigned long flags;
|
|
u32 base;
|
|
|
|
if ((bus > 255) || (devfn > 255) || (reg > 4095))
|
|
return -EINVAL;
|
|
|
|
base = get_base_addr(seg, bus, devfn);
|
|
if (!base)
|
|
return pci_conf1_write(seg,bus,devfn,reg,len,value);
|
|
|
|
spin_lock_irqsave(&pci_config_lock, flags);
|
|
|
|
pci_exp_set_dev_base(base, bus, devfn);
|
|
|
|
switch (len) {
|
|
case 1:
|
|
writeb(value, mmcfg_virt_addr + reg);
|
|
break;
|
|
case 2:
|
|
writew(value, mmcfg_virt_addr + reg);
|
|
break;
|
|
case 4:
|
|
writel(value, mmcfg_virt_addr + reg);
|
|
break;
|
|
}
|
|
|
|
spin_unlock_irqrestore(&pci_config_lock, flags);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct pci_raw_ops pci_mmcfg = {
|
|
.read = pci_mmcfg_read,
|
|
.write = pci_mmcfg_write,
|
|
};
|
|
|
|
/* K8 systems have some devices (typically in the builtin northbridge)
|
|
that are only accessible using type1
|
|
Normally this can be expressed in the MCFG by not listing them
|
|
and assigning suitable _SEGs, but this isn't implemented in some BIOS.
|
|
Instead try to discover all devices on bus 0 that are unreachable using MM
|
|
and fallback for them.
|
|
We only do this for bus 0/seg 0 */
|
|
static __init void unreachable_devices(void)
|
|
{
|
|
int i;
|
|
unsigned long flags;
|
|
|
|
for (i = 0; i < 32; i++) {
|
|
u32 val1;
|
|
u32 addr;
|
|
|
|
pci_conf1_read(0, 0, PCI_DEVFN(i, 0), 0, 4, &val1);
|
|
if (val1 == 0xffffffff)
|
|
continue;
|
|
|
|
/* Locking probably not needed, but safer */
|
|
spin_lock_irqsave(&pci_config_lock, flags);
|
|
addr = get_base_addr(0, 0, PCI_DEVFN(i, 0));
|
|
if (addr != 0)
|
|
pci_exp_set_dev_base(addr, 0, PCI_DEVFN(i, 0));
|
|
if (addr == 0 || readl((u32 __iomem *)mmcfg_virt_addr) != val1)
|
|
set_bit(i, fallback_slots);
|
|
spin_unlock_irqrestore(&pci_config_lock, flags);
|
|
}
|
|
}
|
|
|
|
static int __init pci_mmcfg_init(void)
|
|
{
|
|
if ((pci_probe & PCI_PROBE_MMCONF) == 0)
|
|
goto out;
|
|
|
|
acpi_table_parse(ACPI_MCFG, acpi_parse_mcfg);
|
|
if ((pci_mmcfg_config_num == 0) ||
|
|
(pci_mmcfg_config == NULL) ||
|
|
(pci_mmcfg_config[0].base_address == 0))
|
|
goto out;
|
|
|
|
printk(KERN_INFO "PCI: Using MMCONFIG\n");
|
|
raw_pci_ops = &pci_mmcfg;
|
|
pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;
|
|
|
|
unreachable_devices();
|
|
|
|
out:
|
|
return 0;
|
|
}
|
|
|
|
arch_initcall(pci_mmcfg_init);
|