dect
/
linux-2.6
Archived
13
0
Fork 0
This repository has been archived on 2022-02-17. You can view files and clone it, but cannot push or open issues or pull requests.
linux-2.6/sound/atmel
Julia Lawall 0c23e46eb4 ALSA: sound/atmel/ac97c.c: fix error return code
In the first case, the second test of whether retval is negative is
redundant.  It is dropped and the previous and subsequent tests are
combined.

In the second case, add an initialization of retval on failure of ioremap.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2012-08-20 10:56:01 +02:00
..
Kconfig ALSA: AC97: add AC97 support for AT91. 2010-03-25 20:22:15 +01:00
Makefile ALSA: Add ALSA driver for Atmel AC97 controller 2009-02-05 15:08:51 +01:00
abdac.c ALSA: sound/atmel/abdac.c: fix error return code 2012-08-20 10:53:13 +02:00
ac97c.c ALSA: sound/atmel/ac97c.c: fix error return code 2012-08-20 10:56:01 +02:00
ac97c.h ALSA: snd-atmel-ac97c: cleanup register definitions 2009-04-06 03:54:48 +02:00