280f37afa2
This patch fixes a problem when you use 32 nodes in the cluster match: % iptables -I PREROUTING -t mangle -i eth0 -m cluster \ --cluster-total-nodes 32 --cluster-local-node 32 \ --cluster-hash-seed 0xdeadbeef -j MARK --set-mark 0xffff iptables: Invalid argument. Run `dmesg' for more information. % dmesg | tail -1 xt_cluster: this node mask cannot be higher than the total number of nodes The problem is related to this checking: if (info->node_mask >= (1 << info->total_nodes)) { printk(KERN_ERR "xt_cluster: this node mask cannot be " "higher than the total number of nodes\n"); return false; } (1 << 32) is 1. Thus, the checking fails. BTW, I said this before but I insist: I have only tested the cluster match with 2 nodes getting ~45% extra performance in an active-active setup. The maximum limit of 32 nodes is still completely arbitrary. I'd really appreciate if people that have more nodes in their setups let me know. Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Patrick McHardy <kaber@trash.net>
18 lines
305 B
C
18 lines
305 B
C
#ifndef _XT_CLUSTER_MATCH_H
|
|
#define _XT_CLUSTER_MATCH_H
|
|
|
|
enum xt_cluster_flags {
|
|
XT_CLUSTER_F_INV = (1 << 0)
|
|
};
|
|
|
|
struct xt_cluster_match_info {
|
|
u_int32_t total_nodes;
|
|
u_int32_t node_mask;
|
|
u_int32_t hash_seed;
|
|
u_int32_t flags;
|
|
};
|
|
|
|
#define XT_CLUSTER_NODES_MAX 32
|
|
|
|
#endif /* _XT_CLUSTER_MATCH_H */
|