b202445925
This changes the ordering of initialization and probing events from: 1/ allocate rphy in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN 2/ allocate ata_port and schedule port probe in DISCE_PROBE ...to: 1/ allocate ata_port in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN 2/ allocate rphy in PORTE_BYTES_DMAED, DISCE_REVALIDATE_DOMAIN 3/ schedule port probe in DISCE_PROBE This ordering prevents PHYE_SIGNAL_LOSS_EVENTS from sneaking in to destrory ata devices before they have been fully initialized: BUG: unable to handle kernel paging request at 0000000000003b10 IP: [<ffffffffa0053d7e>] sas_ata_end_eh+0x12/0x5e [libsas] ... [<ffffffffa004d1af>] sas_unregister_common_dev+0x78/0xc9 [libsas] [<ffffffffa004d4d4>] sas_unregister_dev+0x4f/0xad [libsas] [<ffffffffa004d5b1>] sas_unregister_domain_devices+0x7f/0xbf [libsas] [<ffffffffa004c487>] sas_deform_port+0x61/0x1b8 [libsas] [<ffffffffa004bed0>] sas_phye_loss_of_signal+0x29/0x2b [libsas] ...and kills the awkward "sata domain_device briefly existing in the domain without an ata_port" state. Reported-by: Michal Kosciowski <michal.kosciowski@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Acked-by: Jeff Garzik <jgarzik@redhat.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
91 lines
2.4 KiB
C
91 lines
2.4 KiB
C
/*
|
|
* Support for SATA devices on Serial Attached SCSI (SAS) controllers
|
|
*
|
|
* Copyright (C) 2006 IBM Corporation
|
|
*
|
|
* Written by: Darrick J. Wong <djwong@us.ibm.com>, IBM Corporation
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
|
|
* USA
|
|
*
|
|
*/
|
|
|
|
#ifndef _SAS_ATA_H_
|
|
#define _SAS_ATA_H_
|
|
|
|
#include <linux/libata.h>
|
|
#include <scsi/libsas.h>
|
|
|
|
#ifdef CONFIG_SCSI_SAS_ATA
|
|
|
|
static inline int dev_is_sata(struct domain_device *dev)
|
|
{
|
|
return dev->dev_type == SATA_DEV || dev->dev_type == SATA_PM ||
|
|
dev->dev_type == SATA_PM_PORT || dev->dev_type == SATA_PENDING;
|
|
}
|
|
|
|
int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy);
|
|
int sas_ata_init(struct domain_device *dev);
|
|
void sas_ata_task_abort(struct sas_task *task);
|
|
void sas_ata_strategy_handler(struct Scsi_Host *shost);
|
|
void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q,
|
|
struct list_head *done_q);
|
|
void sas_ata_schedule_reset(struct domain_device *dev);
|
|
void sas_ata_wait_eh(struct domain_device *dev);
|
|
void sas_probe_sata(struct asd_sas_port *port);
|
|
#else
|
|
|
|
|
|
static inline int dev_is_sata(struct domain_device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline int sas_ata_init(struct domain_device *dev)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline void sas_ata_task_abort(struct sas_task *task)
|
|
{
|
|
}
|
|
|
|
static inline void sas_ata_strategy_handler(struct Scsi_Host *shost)
|
|
{
|
|
}
|
|
|
|
static inline void sas_ata_eh(struct Scsi_Host *shost, struct list_head *work_q,
|
|
struct list_head *done_q)
|
|
{
|
|
}
|
|
|
|
static inline void sas_ata_schedule_reset(struct domain_device *dev)
|
|
{
|
|
}
|
|
|
|
static inline void sas_ata_wait_eh(struct domain_device *dev)
|
|
{
|
|
}
|
|
|
|
static inline void sas_probe_sata(struct asd_sas_port *port)
|
|
{
|
|
}
|
|
|
|
static inline int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy)
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
#endif /* _SAS_ATA_H_ */
|